Add span report to local testing task #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
noahsmartin
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds span detection/support to the local debug run printer. Leverages perfetto under the hood (specifically the new
PerfettoTraceAPI rolling out in 1.2.0 of benchmark) to run a perfetto trace across the method invocation allowing us to detect all spans from the target app.Handles success, missing and warning states, examples below. Arbitrarily sets a variance warning for spans < 200ms.
Success
Warning (< 200ms)
Error (missing)
Edge cases (multi span, one exists, one missing | startup test - no spans)
Resolves ET-2039