-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recursive lookup for transitive preview annotations #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbro112
reviewed
Sep 28, 2023
@@ -25,8 +25,7 @@ fun TextRowWithIcon( | |||
} | |||
|
|||
@Preview | |||
@FontScalePreviews | |||
@LocalePreviews | |||
@SnapshotTestingPreview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit: Could we make this a separate preview to make sure we can test both the outputs of stacked multipreviews directly on the composable and from the stacked multipreview annotation?
rbro112
approved these changes
Sep 29, 2023
rbro112
changed the base branch from
telkins/find-module-annotations
to
main
September 29, 2023 16:56
rbro112
force-pushed
the
telkins/find-transitive-previews
branch
from
September 29, 2023 16:56
61d4dcd
to
57419d7
Compare
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of correctly resolving multi-previews, now we can resolve arbitrary levels of multi-preview annotations.
@Preview
annotation by recursively checking annotation classes. Transitive@Preview
annotations would be those from a multi-preview.Testing:
I created a new
@SnapshotTestingPreview
and updated some existing previews to use this new annotation. The snapshot output is still the same: