Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ratings popup #187

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding ratings popup #187

wants to merge 3 commits into from

Conversation

Rahkeen
Copy link
Collaborator

@Rahkeen Rahkeen commented Oct 16, 2024

Playing with In-App Review APIs

Copy link
Collaborator Author

Rahkeen commented Oct 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Rahkeen Rahkeen marked this pull request as ready for review October 16, 2024 22:29
Copy link

emerge-tools bot commented Oct 16, 2024

2 builds increased size

Name Version Download Change Install Change Approval
⚠️ Hacker News
com.emergetools.hackernews.debug
1.0.1-internal (12) 13.4 MB ⬆️ 273.7 kB (2.08%) 38.2 MB ⬆️ 664.8 kB (1.77%) N/A
Hacker News
com.emergetools.hackernews
1.0.1-internal (12) 3.0 MB ⬆️ 11.1 kB (0.37%) 6.9 MB ⬆️ 22.1 kB (0.32%) N/A

Hacker News 1.0.1-internal (12)
com.emergetools.hackernews.debug

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 664.8 kB (1.77%)
Total download size change: ⬆️ 273.7 kB (2.08%)

Largest size changes

Item Install Size Change Download Size Change
📝 androidx.fragment.app.FragmentManagerImpl ⬆️ 30.6 kB ⬆️ 11.0 kB
📝 androidx.viewpager.widget.ViewPager ⬆️ 24.0 kB ⬆️ 8.7 kB
📝 androidx.fragment.app.Fragment ⬆️ 15.8 kB ⬆️ 5.7 kB
resources.arsc ⬆️ 11.1 kB ⬆️ 4.8 kB
📝 androidx.customview.widget.ViewDragHelper ⬆️ 9.9 kB ⬆️ 3.6 kB
View Treemap

Image of diff

Hacker News 1.0.1-internal (12)
com.emergetools.hackernews

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 22.1 kB (0.32%)
Total download size change: ⬆️ 11.1 kB (0.37%)

Largest size changes

Item Install Size Change Download Size Change
📝 com.google.android.gms.tasks.zzw ⬆️ 2.4 kB ⬆️ 1.1 kB
📝 com.google.android.gms.tasks.zzr ⬆️ 2.4 kB ⬆️ 1.1 kB
🗑 androidx.compose.ui.node.DepthSortedSet ⬇️ -2.1 kB ⬇️ -944 B
🗑 androidx.compose.material.ripple.StateLayer ⬇️ -1.8 kB ⬇️ -794 B
Other ⬆️ 21.2 kB ⬆️ 10.7 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

Copy link

emerge-tools bot commented Oct 16, 2024

📸 Snapshot Test

Some snapshots failed to render

Name Version Added Removed Modified Unchanged Errored Approval
Hacker News
com.emergetools.hackernews.debug
1.0.1-internal (12) 0 0 0 71 8 N/A

🛸 Powered by Emerge Tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant