Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed out directive for viewtransition function #302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frivolousvision
Copy link

Hi, I'd like to propose that the out directive be removed for the viewtransition function for transitions on navigation.

Currently, when navigating between routes and when using the fade transition from "svelte/transition", both the old and new incoming route components immediately become visible and are relatively, vertically "stacked." One routes' components are above and the other's below, potentially increasing the page height. Then both fade out concurrently for the duration set, with the 'fade in' seemingly having no effect.

Alternatively, if removing of the out directive is not ideal and there are use cases for other transitions where both the in and out directives are necessary, another approach could be to pass an additional key/value in the viewtransition prop object like:

viewtransition="{() => ({ fn: fade, duration: 500, inOnly: true })}"

Where in this case we could delineate either inOnly: true, outOnly: true or simply omit the field to maintain the current implementation.

Taking this approach, the new viewtransitionFn could look something like:

const viewtransitionFn = (node, _, direction) => {
    const vt = viewtransition(direction);
    if (typeof vt?.fn === "function") {
        if (vt?.inOnly && direction.direction === "out") {
            vt.duration = 0;
        } else if (vt?.outOnly && direction.direction === "in") {
            vt.duration = 0;
        }
        return vt.fn(node, vt);
    } else return vt;
};

In this approach, when choosing to use only the in or out directive, the duration of the opposite directive is set to 0, essentially removing its effect.

Would love to know what you think! Happy to make another a PR for the latter approach if necessary. Thank you!

@krishnaTORQUE
Copy link
Collaborator

Thanks for the PR
I will review & merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants