Skip to content

Commit

Permalink
Don't require to shell-escape conf_overrides
Browse files Browse the repository at this point in the history
Use heredoc syntax to append the value of `conf_overrides` to the
`local.conf` file. Compared to the previous solution using `echo`, this
removes the need to shell escape your value.

Also remove the useless test, since the default value for
`inputs.conf_overrides` is an empty string which results in a noop.

Fixes #19.
  • Loading branch information
mandre committed Mar 11, 2024
1 parent c41f86d commit 81537f2
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ runs:
echo "ENABLED_SERVICES+=${ENABLED_SERVICES}" >> local.conf
# This must stay at the end to allow any overrides
if [[ "${{ inputs.conf_overrides }}" != "" ]]; then
echo "${{ inputs.conf_overrides }}" >> local.conf
fi
cat << EOF_CONF_OVERRIDES >> local.conf
${{ inputs.conf_overrides }}
EOF_CONF_OVERRIDES
working-directory: ./devstack
shell: bash
- name: Run devstack
Expand Down

0 comments on commit 81537f2

Please sign in to comment.