Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reflection-based debugging #83

Merged
merged 24 commits into from
Feb 25, 2024
Merged

Remove reflection-based debugging #83

merged 24 commits into from
Feb 25, 2024

Conversation

EmiyaSyahriel
Copy link
Owner

Since the kotlin.reflect package is only made available in debug and dex, the import statement will cause build error when creating release apk. And unfortunately, It seems that Kotlin does not have any language feature that is similar to conditional symbol (C#) or conditional preprocessor (C/C++), the only possible is using static code analysis (or anything it is called) which is done after checking imports, Therefore conditionally disabling the import statement is impossible.

So I removed the reflection-based debugging code and library dependency and make the debugged class visibility to internal instead, as it is still inside the vshlauncher module.

Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
fix: Text for invalid setting page dialog

Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
TODO: need better handling in the future
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
add: onResume callback

Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
@EmiyaSyahriel EmiyaSyahriel merged commit b392d16 into master Feb 25, 2024
2 checks passed
@EmiyaSyahriel EmiyaSyahriel deleted the local_development branch February 25, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant