-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reflection-based debugging #83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
fix: Text for invalid setting page dialog Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
TODO: need better handling in the future Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
add: onResume callback Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
kotlin.reflect
package is only made available indebug
anddex
, the import statement will cause build error when creatingrelease
apk. And unfortunately, It seems that Kotlin does not have any language feature that is similar to conditional symbol (C#) or conditional preprocessor (C/C++), the only possible is using static code analysis (or anything it is called) which is done after checking imports, Therefore conditionally disabling the import statement is impossible.So I removed the reflection-based debugging code and library dependency and make the debugged class visibility to
internal
instead, as it is still inside the vshlauncher module.