-
Notifications
You must be signed in to change notification settings - Fork 36
Updated documentation for the changes to the EJS_Buttons variable #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michael-j-green
wants to merge
5
commits into
main
Choose a base branch
from
custom-button-documentation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+93
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c98306b
Updated documentation for the changes to the EJS_Buttons variable
michael-j-green 9e3e569
Added more detail to the documentation.
michael-j-green 4f7cead
Added "don't use internal API's warning"
michael-j-green ea53e6d
Documentation changes
michael-j-green c35c85d
Completed requested changes
michael-j-green File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought it might be prudent to put this alert on this page. Devs accessing internal functions and API's is never a good idea as we can get hamstrung by trying to maintain compatibility with internal functions. We should only support ones we've publicly documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I like the idea - we have no internal APIs documented at the moment, which would make gaseous and romm both under the "usage of undocumented apis" (and me under recommending undocumented apis)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m thinking we still flag it and if Gaseous and Romm (and others) are using internal API’s we should try to transition to public ones.
Current versions of Gaseous aren’t using internal API’s so I’m not affected yet.
@gantoine; what do you think from a Romm point of view?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the snippet makes sense, and we'll handle the use of undocumented methods internally. The version we use is pinned so the emulatorjs team is free to make whatever breaking changes they want (public facing or not), and we'll handle the upgrade!