Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check_video.py #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mst-rajatmishra
Copy link

@mst-rajatmishra mst-rajatmishra commented Oct 24, 2024

Hii,
i have tried making some changes and improvements,

In Check_Video.py

  • Used try-except blocks when working with video files to handle potential errors more gracefully (e.g., if the video cannot be opened).
  • It might be helpful to print out the properties of the videos for easier debugging or verification.
  • Consider adding docstrings to your functions for better clarity on their purpose.
  • Instead of using assert, which can be disabled with optimization flags in Python, consider raising exceptions with clear error messages.

In Distortion.py

  • Each function includes a docstring for clarity.
  • Added checks for parameter values to prevent invalid usage.
  • Improved variable naming and formatting for better readability.

Thank You,
Rajat Mishra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant