Skip to content

Commit

Permalink
Fix tests.
Browse files Browse the repository at this point in the history
  • Loading branch information
defectiveAi committed Jan 24, 2025
1 parent e5a3c21 commit 48d8c55
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public async Task GetActorsAssociatedWithExternalUserId_GivenUserId_ReturnsActor
await using var scope = host.BeginScope();
var mediator = scope.ServiceProvider.GetRequiredService<IMediator>();

var actor = await _fixture.PrepareActorAsync();
var actor = await _fixture.PrepareActiveActorAsync();
var user = await _fixture.PrepareUserAsync();
var userRole = await _fixture.PrepareUserRoleAsync(PermissionId.UsersManage);
await _fixture.AssignUserRoleAsync(user.Id, actor.Id, userRole.Id);
Expand Down Expand Up @@ -125,7 +125,7 @@ public async Task GetActorsAssociatedWithExternalUserId_GivenOpenId_ReturnsActor
var externalUserId = await _graphServiceClientFixture.CreateUserAsync(openIdUserEmail);
var openIdExternalUserId = await _graphServiceClientFixture.CreateUserAsync(openIdUserEmail, openIdIdentity);

var actor = await _fixture.PrepareActorAsync();
var actor = await _fixture.PrepareActiveActorAsync();
var user = await _fixture.PrepareUserAsync(TestPreparationEntities.UnconnectedUser.Patch(u => u.ExternalId = externalUserId.Value));
var userRole = await _fixture.PrepareUserRoleAsync(PermissionId.UsersManage);
await _fixture.AssignUserRoleAsync(user.Id, actor.Id, userRole.Id);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public GetSelectionActorsQueryHandlerIntegrationTests(MarketParticipantDatabaseF
}

[Fact]
public async Task GetSelectionActors_GivenUserId_ReturnsActors()
public async Task GetSelectionActors_InactiveActor_ReturnsEmptyList()
{
// arrange
await using var host = await WebApiIntegrationTestHost.InitializeAsync(_fixture);
Expand All @@ -56,6 +56,28 @@ public async Task GetSelectionActors_GivenUserId_ReturnsActors()
// act
var actual = await mediator.Send(command);

// assert
Assert.Empty(actual.Actors);
}

[Fact]
public async Task GetSelectionActors_GivenUserId_ReturnsActors()
{
// arrange
await using var host = await WebApiIntegrationTestHost.InitializeAsync(_fixture);
await using var scope = host.BeginScope();
var mediator = scope.ServiceProvider.GetRequiredService<IMediator>();

var actor = await _fixture.PrepareActiveActorAsync();
var user = await _fixture.PrepareUserAsync();
var userRole = await _fixture.PrepareUserRoleAsync(PermissionId.UsersManage);
await _fixture.AssignUserRoleAsync(user.Id, actor.Id, userRole.Id);

var command = new GetSelectionActorsQueryCommand(user.Id);

// act
var actual = await mediator.Send(command);

// assert
Assert.Single(actual.Actors);
Assert.Equal(actor.Id, actual.Actors.Single().Id);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,12 @@ public async Task GetAssociatedUserActorsAsync_UnknownUser_ReturnsEmptyList()
}

[Fact]
public async Task GetAssociatedUserActorsAsync_GivenUser_ReturnsEmptyList()
public async Task GetAssociatedUserActorsAsync_GivenUser_ReturnsActorId()
{
// Arrange
const string target = "user/actors";

var actor = await _fixture.PrepareActorAsync();
var actor = await _fixture.PrepareActiveActorAsync();
var user = await _fixture.PrepareUserAsync();
var userRole = await _fixture.PrepareUserRoleAsync(PermissionId.ActorsManage);
await _fixture.AssignUserRoleAsync(user.Id, actor.Id, userRole.Id);
Expand Down

0 comments on commit 48d8c55

Please sign in to comment.