Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the constraint defining curtailment for to the constraints_capacity method. #10

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

sigmundholm
Copy link
Collaborator

This will make it easier to rewrite this constraint for other packages, and also allows simplifying the code by removing the create_node method for NonDisRES entirely, since it is now identical to the create_node method defined for a general Source node in EnergyModelsBase.

…ints_capacity method.

This will make it easier to rewrite this constraint for other packages, and also allows simplifying the code by removing the create_node method for NonDisRES entierly, since it is now identical to the create_node method defined for a general Source node in EMB.
@sigmundholm sigmundholm marked this pull request as draft March 1, 2024 11:51
@sigmundholm sigmundholm marked this pull request as ready for review March 1, 2024 13:36
Copy link
Member

@JulStraus JulStraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. We can keep the comment in at the time being, while we will remove it eventually.

@JulStraus JulStraus merged commit c5df45a into EnergyModelsX:main Mar 3, 2024
6 checks passed
@JulStraus JulStraus added the enhancement New feature or request label Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants