Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of checks and tests #12

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Improvement of checks and tests #12

merged 3 commits into from
Mar 4, 2024

Conversation

JulStraus
Copy link
Member

This PR reworks the checks and tests, similar to PR18 in EMB:

  1. Added general checks for capacity to the individual checks. These are in practice the same as in PR18 of EMB, but I want to specifically avoid to have a structure as in variable creation to have freedom in the creation of new nodes.
  2. Added tests for the checks so that we aware of problems in the checks.
  3. Moved the functions and utils which were previously in runtests.jl to a separate file, utils.jl.

Minor additional change:

  • I updated the NEWS.md to follow the style from markdownlint, I was to annoyed by the constant warnings.

- Moved test utils to separate file
- Added tests that the checks are working
@JulStraus JulStraus added the enhancement New feature or request label Mar 3, 2024
@JulStraus JulStraus self-assigned this Mar 3, 2024
@JulStraus JulStraus merged commit 58a00e1 into main Mar 4, 2024
6 checks passed
@JulStraus JulStraus deleted the enhanc/checks-tests branch March 4, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants