fix: Fixed CS1591 warnings about missing XML comments #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please fix conflict |
EngRajabi
reviewed
Mar 10, 2024
| @@ -0,0 +1,21 @@ | |||
| namespace Supernova.Enum.Generators; | |||
|
|
|||
| public static class EnumGeneratorAttributeHelper | |||
There was a problem hiding this comment.
Was there a special reason that you separated these features from the SourceGeneratorHelper class?
There was a problem hiding this comment.
This separation follows the single responsibility principle and helps keep the project organized. Based on the file name, it is now clear what this file does without having to open it.
EngRajabi
reviewed
Mar 10, 2024
| namespace " + SourceGeneratorHelper.NameSpace + @" | ||
| { | ||
| [AttributeUsage(AttributeTargets.Enum)] | ||
| [GeneratedCodeAttribute(""Supernova.Enum.Generators"", null)] |
There was a problem hiding this comment.
Does adding Generated Code Attribute make a special change?
There was a problem hiding this comment.
It's a support attribute for tools that use Reflection for analysis. Does the same thing as the auto-generated tag for tools that not uses a Reflection approach.
|
Master merged into branch |
|
fix with commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66