Port to 1.21.1 #240
Open
Port to 1.21.1 #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix ObfuscationReflectionHelper#setPrivateValue using SRG mapped names, Neoforge has switched to mojmap at runtime
IThundxr
force-pushed
the
feat/multi-loader-1.21
branch
from
34eba91
to
2f83dcc
Compare
# Conflicts: # gradle.properties
IThundxr
force-pushed
the
feat/multi-loader-1.21
branch
from
2f04d9b
to
a9c4e5c
Compare
…at/multi-loader-1.21
…at/multi-loader-1.21 # Conflicts: # common/src/lib/java/dev/engine_room/flywheel/lib/material/Materials.java # common/src/lib/java/dev/engine_room/flywheel/lib/model/baked/MeshHelper.java # common/src/lib/java/dev/engine_room/flywheel/lib/visual/component/ShadowComponent.java # common/src/main/java/dev/engine_room/flywheel/impl/mixin/LevelRendererMixin.java # common/src/main/java/dev/engine_room/flywheel/impl/mixin/visualmanage/SectionCompilerMixin.java # forge/src/api/java/dev/engine_room/flywheel/api/event/BeginFrameEvent.java # forge/src/api/java/dev/engine_room/flywheel/api/event/RenderStageEvent.java # forge/src/lib/java/dev/engine_room/flywheel/lib/model/baked/PartialModelEventHandler.java # forge/src/main/java/dev/engine_room/flywheel/impl/FlwImplXplatImpl.java # forge/src/main/java/dev/engine_room/flywheel/impl/mixin/sodium/ChunkBuilderMeshingTaskMixin.java
…at/multi-loader-1.21
# Conflicts: # common/src/lib/java/dev/engine_room/flywheel/lib/model/part/ModelPartConverter.java # forge/src/main/java/dev/engine_room/flywheel/impl/ForgeFlwConfig.java # gradle.properties
# Conflicts: # forge/src/main/java/dev/engine_room/flywheel/impl/ForgeFlwConfig.java
IThundxr
force-pushed
the
feat/multi-loader-1.21
branch
from
64a0c0d
to
4c5894c
Compare
IThundxr
force-pushed
the
feat/multi-loader-1.21
branch
from
4c5894c
to
ae4e4e7
Compare
Jozufozu
requested changes
Oct 12, 2024
forge/src/main/java/dev/engine_room/flywheel/impl/FlywheelForge.java
Outdated
Show resolved
Hide resolved
forge/src/main/java/dev/engine_room/flywheel/impl/FlywheelForge.java
Outdated
Show resolved
Hide resolved
common/src/main/java/dev/engine_room/flywheel/impl/compat/CompatMods.java
Outdated
Show resolved
Hide resolved
common/src/main/java/dev/engine_room/flywheel/impl/compat/CompatMods.java
Outdated
Show resolved
Hide resolved
forge/src/main/java/dev/engine_room/flywheel/impl/FlywheelForge.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/kotlin/dev/engine_room/gradle/subproject/SubprojectPlugin.kt
Outdated
Show resolved
Hide resolved
common/src/lib/java/dev/engine_room/flywheel/lib/model/part/VertexWriter.java
Show resolved
Hide resolved
forge/src/lib/java/dev/engine_room/flywheel/lib/model/baked/MeshEmitter.java
Show resolved
Hide resolved
|
This PR seems to have a bug that compleatly breaks the hitbox entity component. The fire one might also be broken, but I have no easy repro. Image of the issue
Repro steps:
The issue disappears after reloading chunks with F3+A and sometimes reappears in after rejoining the game. An alternative form of the bug can also appear after F3+A with some combination of reloads and hitbox toggles, which looks like this: Image of the alternative form
I have no idea what's going on, but its very broken. |
Jozufozu
requested changes
Oct 14, 2024
fabric/src/lib/java/dev/engine_room/flywheel/lib/model/baked/MeshEmitter.java
Outdated
Show resolved
Hide resolved
forge/src/lib/java/dev/engine_room/flywheel/lib/model/baked/MeshEmitter.java
Outdated
Show resolved
Hide resolved
fabric/src/lib/java/dev/engine_room/flywheel/lib/model/baked/MeshEmitter.java
Show resolved
Hide resolved
…er-1.21 # Conflicts: # common/src/lib/java/dev/engine_room/flywheel/lib/util/ShadersModHandler.java # common/src/main/java/dev/engine_room/flywheel/impl/FlwImplXplat.java # common/src/main/java/dev/engine_room/flywheel/impl/compat/SodiumCompat.java # common/src/main/java/dev/engine_room/flywheel/impl/mixin/BlockEntityTypeMixin.java # fabric/build.gradle.kts # fabric/src/main/java/dev/engine_room/flywheel/impl/FlwImplXplatImpl.java # fabric/src/main/java/dev/engine_room/flywheel/impl/FlwLibXplatImpl.java # fabric/src/main/java/dev/engine_room/flywheel/impl/mixin/sodium/ChunkBuilderMeshingTaskMixin.java # fabric/src/main/java/dev/engine_room/flywheel/impl/mixin/sodium/SodiumMixinPlugin.java # fabric/src/main/resources/fabric.mod.json # forge/build.gradle.kts # forge/src/main/java/dev/engine_room/flywheel/impl/FlwImplXplatImpl.java # forge/src/main/java/dev/engine_room/flywheel/impl/FlwLibXplatImpl.java # forge/src/main/java/dev/engine_room/flywheel/impl/FlywheelForge.java # forge/src/main/resources/META-INF/neoforge.mods.toml # gradle.properties # gradle/wrapper/gradle-wrapper.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.