Deprecate the concept of bundled block data #2447
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me4502
force-pushed
the
chore/deprecate-bundled-data
branch
from
71a1fc4 to
bb94a07
Compare
me4502
force-pushed
the
chore/deprecate-bundled-data
branch
2 times, most recently
from
34a4e16 to
b779819
Compare
me4502
force-pushed
the
chore/deprecate-bundled-data
branch
from
7f4feca to
37fdd65
Compare
me4502
changed the title
...src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/v1_20_R2/PaperweightBlockMaterial.java
Outdated
Show resolved
Hide resolved
wizjany
reviewed
Jan 6, 2025
.../src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/v1_21_4/PaperweightBlockMaterial.java
Show resolved
Hide resolved
wizjany
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the concept of bundled block data, and removes it from all non-CLI platforms.
To fully remove it from CLI, we'll have to likely add this data into the current CLI data format, which is out of scope for this PR and a bit of a larger task (new version; also needs to include items etc)
This also, like with the item registry changes, allows us to skip loading of the bundled data on startup. If a plugin is using it for some reason, it'll still load, but by default it won't be loaded into server memory.