统一版本接口 #200
Open
统一版本接口 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phidiaLam
requested changes
Jul 31, 2024
| #[resp_result] | ||
| // TODO: 这里把挂载的东西一起带进去可能会好点？ | ||
| #[instrument(skip_all,fields(version = %arg_2.0))] | ||
| pub async fn release_version( |
There was a problem hiding this comment.
这个写到cdn下面，要上腾讯云cdn，然后接一下之前写刷新cdn的接口在逻辑层那些改动的地方
phidiaLam
requested changes
Aug 1, 2024
| @@ -51,6 +51,6 @@ type OperateResult<T> = Result<T, OperateError>; | |||
|
|
|||
| impl<'db, Conn> OperationDatabaseOperate<'db, Conn> { | |||
| pub fn plugin_version(&self) -> PluginVersionOperate<'_, Conn> { | |||
| self.child() | |||
| SuperOperate::child(self) | |||
phidiaLam
requested changes
Aug 2, 2024
There was a problem hiding this comment.
这边要上cdn，不需要自己搞这个modify cache了吧
Comment on lines
+43
to
+45
| Chrome, | ||
| Firefox, | ||
| Edge, |
Comment on lines
+51
to
+53
| let sort = doc! { | ||
| "$natural": -1i32 | ||
| }; |
There was a problem hiding this comment.
这边改成“_id”可能更好点？nature就是原本mongo文件顺序
There was a problem hiding this comment.
_id 是和时间相关的吗？如果是那也行
Comment on lines
+30
to
+48
| // 找到当前平台的最新的发布版本，与当前添加版本比较。新版本必须更新 | ||
| let filter = doc! {"platform":to_bson(&release_version.platform)?}; | ||
| let exist_latest_version = collection | ||
| .with_mapping::<VersionOnly>() | ||
| .doing(|collection| { | ||
| collection.find_one( | ||
| filter, | ||
| FindOneOptions::builder() | ||
| .sort(doc! {"$natural": -1i32}) | ||
| .projection(doc! {"version":1i32}) | ||
| .build(), | ||
| ) | ||
| }) | ||
| .await?; | ||
| if let Some(VersionOnly { version }) = exist_latest_version { | ||
| if release_version.version <= version { | ||
| Err(Error::VersionTooOld(version, release_version.platform))?; | ||
| } | ||
| } |
There was a problem hiding this comment.
这边可能还要支持一下update delete，update delete支持新表就够了。还有个日志列表，去包含版本、更新内容、平台这些信息，给后端做分页表格查询用，也给前端展示历史更新用
There was a problem hiding this comment.
update delete是声明意思？
- 什么是表新？
- 日志列表就是全部历史版本？
| .build(), | ||
| ) | ||
| .extend_download_source( | ||
| ["Chrome", "Edge", "FireFox"] |
| ) | ||
| .add_download_source( | ||
| DownloadSourceItem::builder() | ||
| .name("ZIP") |
phidiaLam
requested changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
统一版本接口