-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable modules with commands #1656
base: main
Are you sure you want to change the base?
Conversation
…ments for Firebase configuration
…pp Store submission
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done a single pass on code based, I'll do another pass with actual running the command.
So, main advantage I see right now is it based on starter so always in sync but uses a lot of string and regex manipulation which we need to find better way.
@@ -20,10 +20,33 @@ allprojects { | |||
|
|||
rootProject.buildDir = '../build' | |||
subprojects { | |||
afterEvaluate { project -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to log, can you share which modules still breaks with out this manual override?
This was specifically add for high_chart which we removed, might want to update/remove other modules instead of force update on all package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these modules causes the problems
- Auth
- Camera (QR Code)
- Connect
Not sure if others too, have to create builds 1 by 1 for each to be sure
Also, this is part does project setup and rest app signing and deployment to respected store will be handle by? |
yes, starter commands are only responsible for enabling the modules, and generating keystore (if needed) The rest of the process is managed in a separate repository: https://github.com/EnsembleUI/build-system. This repository handles additional setup tasks and executes the necessary commands for the project. |
…mbleUI/ensemble into enable-modules-with-scripts
commands to enable modules
ensemble_camera:
npm run hasCamera
ensemble_file_manager :
npm run hasFiles
ensemble_contacts:
npm run hasContacts
ensemble_connect:
npm run hasConnect
ensemble_location:
npm run hasLocation
ensemble_deeplink:
npm run hasDeeplink
notifications:
npm run hasNotifications
ensemble_firebase_analytics
npm run hasFirebaseAnalytics
enable multiple modules with a single command
Generate Keystore