This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
Persist webview preview through vscode restarts #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks cool! i will test this when i leave work |
|
Thanks for the feedback! I think I fixed everything. |
|
LGTM |
Enter-tainer
approved these changes
Jun 23, 2024
There was a problem hiding this comment.
generally LGTM. BTW we are integrating typst-preview into tinymist (see Myriad-Dreamin/tinymist#323). So this patch will be cherrypicked to tinymist after it got merged
|
Should I move this PR to Tinymist? |
|
This fix #153 |
It's not necessary. We will do it. But it's good to send following PR(if there is any) to tinymist. |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This is a small PR implementing the serialization feature which lets the webviews persist over VSCode restarts :)
To see its effect, try opening up a Typst Preview inside VSCode, then run the "Developer: Reload Window" command or close and open VSCode. Before this PR, the Typst Preview would cease to exist. After it, it should re-load.