Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDK configuration for maintainance stacks to experimental deployment #1480

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

addis-samtek
Copy link
Contributor

Deploy Maintenance API to Ephemeral Environment

Resolves #EREGCSC-2861

Description

This pull request changes:

  • Implements automated deployment of Maintenance API to ephemeral environments for PR testing
  • Adds GitHub Actions workflow for PR-specific stack deployment
  • Matches exact configuration from existing serverless deployment:
    • Lambda: Python 3.12, 1024MB, 30s timeout
    • API Gateway: Edge endpoint with binary media types
    • IAM: Correct paths and permission boundaries
    • Logging: Proper CloudWatch configuration

Steps to manually verify this change:

  1. Open a new PR

    • Verify GitHub Action triggers automatically
    • Check CDK deployment logs show correct configurations
  2. Test deployed endpoint

    • Find API Gateway URL aws console
    • Verify maintenance API responds correctly
    • Check AWS Console for PR-specific resources (format: cms-eregs-eph-{pr-number}-maintenance-api)
  3. Close PR to verify cleanup

    • Observe cleanup workflow trigger
    • Verify stack is destroyed
    • Check AWS Console to confirm resource removal

Comments

  1. Resource naming pattern: cms-eregs-eph-{pr-number}-maintenance-api
  2. Matches exactly: memory, timeout, runtime, IAM settings from serverless
  3. Ephemeral resources auto-destroy on PR close/merge

Copy link

✨ See the Django Site in action

Copy link

✨ See the Django Site in action

Copy link

✨ See the Django Site in action

@addis-samtek addis-samtek added the Needs Review This PR needs a code review label Nov 13, 2024
Copy link
Contributor

@cgodwin1 cgodwin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants