Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EREGCSC-2860-B [Hotfix] Remove "hello world" stack deploy from deploy.yml #1481

Merged
merged 1 commit into from
Nov 14, 2024
Merged

EREGCSC-2860-B [Hotfix] Remove "hello world" stack deploy from deploy.yml #1481

merged 1 commit into from
Nov 14, 2024

Conversation

cgodwin1
Copy link
Contributor

Resolves #2860

Description-

Previous PR (#1473) fails to deploy to prod because "deploy.yml" was still looking for the experimental hello world stack.

This pull request changes...

  • Removes the experimental hello world stack deploy action from "deploy.yml"

Steps to manually verify this change...

  1. Approve and merge
  2. Deploy through to prod
  3. Verify green for each deploy

@cgodwin1 cgodwin1 added the Needs Review This PR needs a code review label Nov 13, 2024
@github-actions GitHub Actions
Copy link

✨ See the Django Site in action ✨

PhilR8
PhilR8 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@PhilR8 PhilR8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PhilR8 PhilR8 added Approved and removed Needs Review This PR needs a code review labels Nov 14, 2024
@cgodwin1 cgodwin1 merged commit d7f721e into main Nov 14, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilR8 PhilR8 PhilR8 approved these changes

Assignees
No one assigned
Labels
Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgodwin1 @PhilR8