Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EREGCSC-2041 -- Set up url and configs for OIDC #914

Merged
merged 2 commits into from
Aug 2, 2023
Merged

EREGCSC-2041 -- Set up url and configs for OIDC #914

merged 2 commits into from
Aug 2, 2023

Conversation

thwalker6
Copy link
Contributor

@thwalker6 thwalker6 commented Jul 28, 2023 •
edited
Loading

Resolves # EREGCSC-2041

Description-

In order for us to set up oAuth we need a call back url. This is getting us set up.

This pull request changes...

  • A call back url is set up for our app at {{host}}//oidc/callback/

Steps to manually verify this change...

  1. Go to https://gqhz3je798.execute-api.us-east-1.amazonaws.com/dev914/oidc/callback . You will see a forbidden message. We do not have a client secret yet so it wont work.
  2. Go to the admin panel and log in. You should be able to log in still with the old method of django. You can do this either through your local or the dev site. We expanded the django auth backends to include a new method as well as the old method. Without explicitly adding the old method in settings it will not work.

@thwalker6 thwalker6 temporarily deployed to dev July 28, 2023 18:10 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dev July 28, 2023 18:17 — with GitHub Actions Inactive
@thwalker6 thwalker6 changed the title Set up url and configs for OIDC EREGCSC-2041 -- Set up url and configs for OIDC Jul 28, 2023
@thwalker6 thwalker6 temporarily deployed to dev July 28, 2023 18:22 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dev July 28, 2023 18:22 — with GitHub Actions Inactive
thwalker6
thwalker6 commented Jul 28, 2023
View reviewed changes
.github/workflows/git-secrets.yaml
@@ -4,7 +4,7 @@ jobs:
gitleaks-scan:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitleaks had a warning for using v2 being old so I just changed it to v3. Documentation for gitleaks github action also has it using v3 currently.

thwalker6
thwalker6 commented Jul 28, 2023
View reviewed changes
solution/backend/cmcs_regulations/settings/base.py
OIDC_RP_CLIENT_SECRET = os.environ.get("OIDC_RP_CLIENT_SECRET", None)
OIDC_OP_AUTHORIZATION_ENDPOINT = os.environ.get("OIDC_OP_AUTHORIZATION_ENDPOINT", None)
OIDC_OP_TOKEN_ENDPOINT = os.environ.get("OIDC_OP_TOKEN_ENDPOINT", None)
OIDC_OP_USER_ENDPOINT = os.environ.get("OIDC_OP_USER_ENDPOINT", None)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

putting all of these values into environment variables until we figure out what is a secret and what isnt. Since we dont actually have the token stuff yet we have to set them to none. no impact on the application

@github-actions
Copy link

✨ See the Django Site in action ✨

@thwalker6 thwalker6 temporarily deployed to dev July 28, 2023 18:42 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dev July 28, 2023 18:45 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dev July 28, 2023 18:49 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dev July 28, 2023 18:49 — with GitHub Actions Inactive
@github-actions
Copy link

✨ See the Django Site in action ✨

@thwalker6 thwalker6 marked this pull request as ready for review July 28, 2023 19:18
cgodwin1
cgodwin1 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@cgodwin1 cgodwin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thwalker6 thwalker6 merged commit b15b13e into main Aug 2, 2023
16 checks passed
@thwalker6 thwalker6 temporarily deployed to dev August 2, 2023 12:49 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgodwin1 cgodwin1 cgodwin1 approved these changes

@PhilR8 PhilR8 Awaiting requested review from PhilR8 PhilR8 is a code owner

@peggles2 peggles2 Awaiting requested review from peggles2

Assignees

@cgodwin1 cgodwin1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thwalker6 @cgodwin1