Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oidc removal #921

Merged
merged 3 commits into from
Aug 3, 2023
Merged

oidc removal #921

merged 3 commits into from
Aug 3, 2023

Conversation

thwalker6
Copy link
Contributor

@thwalker6 thwalker6 commented Aug 3, 2023 •
edited
Loading

Resolves #

Description-

There seems to be an issue with django admin when someone changes their password. We arent to sure the cause but it might have something to do with the OIDC login not being fully set up yet. We are seprating the OIDC settings to its own file. OIDC settings will not be used yet. This was going to be done in a later stage but this might fix the issue we are seeing.

This pull request changes...

  • OIDC settings are split into its own settings file. This will not be used yet.

Steps to manually verify this change...

  1. Go to the dev admin site for the experimental branch: https://x3l5zt4in1.execute-api.us-east-1.amazonaws.com/dev921/admin/

  2. login with the account

  3. change the password

  4. log out and log back in.

  5. Prod login for admin is working.

@thwalker6 thwalker6 temporarily deployed to dev August 3, 2023 16:17 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

✨ See the Django Site in action ✨

@thwalker6 thwalker6 temporarily deployed to dev August 3, 2023 16:52 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dev August 3, 2023 16:55 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dev August 3, 2023 16:59 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dev August 3, 2023 16:59 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

✨ See the Django Site in action ✨

@thwalker6 thwalker6 temporarily deployed to dev August 3, 2023 17:12 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dev August 3, 2023 17:16 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dev August 3, 2023 17:20 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dev August 3, 2023 17:20 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

✨ See the Django Site in action ✨

peggles2
peggles2 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@peggles2 peggles2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signed in, changed the password and signed out. I signed back in with new password.
LGTM

@thwalker6 thwalker6 merged commit 6bf7240 into main Aug 3, 2023
16 checks passed
@thwalker6 thwalker6 temporarily deployed to dev August 3, 2023 17:38 — with GitHub Actions Inactive
@thwalker6 thwalker6 deleted the OIDC-removal branch August 3, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peggles2 peggles2 peggles2 approved these changes

@PhilR8 PhilR8 Awaiting requested review from PhilR8 PhilR8 is a code owner

@cgodwin1 cgodwin1 Awaiting requested review from cgodwin1 cgodwin1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thwalker6 @peggles2