Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EREGCSC-2062 -- Put seed data into its own functions #924

Merged
merged 2 commits into from
Aug 14, 2023
Merged

EREGCSC-2062 -- Put seed data into its own functions #924

merged 2 commits into from
Aug 14, 2023

Conversation

thwalker6
Copy link
Contributor

Resolves # EREGCSC-2062

Description-
Currently our lambda and make commands for populating seed data do the exact same thing. This combines them.
This pull request changes...

  • New custom django command of populateseeddata.
  • New file in common for functions. This function handles seed data management.
  • Update the lambda to use the new function instead of having the logic housed in there.
  • Updated some of the seed data for configurations. Just pulled whats currently in prod.

Steps to manually verify this change...

  1. Lambda for populating seed data works correctly on build.
  2. Pull branch on local.
  3. Run "make local.seed"
  4. Your local environment does not break.

@thwalker6 thwalker6 temporarily deployed to dev August 8, 2023 17:05 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dev August 8, 2023 17:13 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dev August 8, 2023 17:18 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dev August 8, 2023 17:18 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

✨ See the Django Site in action ✨

@thwalker6 thwalker6 temporarily deployed to dev August 8, 2023 18:09 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dev August 8, 2023 18:12 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dev August 8, 2023 18:17 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dev August 8, 2023 18:17 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

✨ See the Django Site in action ✨

cgodwin1
cgodwin1 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@cgodwin1 cgodwin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thwalker6 thwalker6 merged commit 9e48dc3 into main Aug 14, 2023
16 checks passed
@thwalker6 thwalker6 temporarily deployed to dev August 14, 2023 12:37 — with GitHub Actions Inactive
@thwalker6 thwalker6 deleted the EREGCSC-2062----Seed-data-functions branch August 14, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgodwin1 cgodwin1 cgodwin1 approved these changes

@PhilR8 PhilR8 Awaiting requested review from PhilR8 PhilR8 is a code owner

@peggles2 peggles2 Awaiting requested review from peggles2

Assignees

@cgodwin1 cgodwin1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thwalker6 @cgodwin1