Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EREGCSC-2296 -- "Sign up for session" link fix #985

Merged
merged 2 commits into from
Oct 6, 2023
Merged

EREGCSC-2296 -- "Sign up for session" link fix #985

merged 2 commits into from
Oct 6, 2023

Conversation

PhilR8
Copy link
Contributor

@PhilR8 PhilR8 commented Oct 6, 2023 •
edited
Loading

Resolves EREGCSC-2296

Description:

The "sign up for a session" link in the homepage footer goes to the homepage. It should go out to a signup google doc.

This pull request changes:

  • Adds SIGNUP_URL back to base.py.

Steps to manually verify this change:

  1. Visit the experimental deployment
  2. The "Sign up for a session" link on the homepage takes you to a google doc and does not refresh the eregs homepage.

@PhilR8 PhilR8 temporarily deployed to dev October 6, 2023 16:26 — with GitHub Actions Inactive
@PhilR8 PhilR8 temporarily deployed to dev October 6, 2023 16:36 — with GitHub Actions Inactive
@PhilR8 PhilR8 temporarily deployed to dev October 6, 2023 16:40 — with GitHub Actions Inactive
@PhilR8 PhilR8 temporarily deployed to dev October 6, 2023 16:40 — with GitHub Actions Inactive
@PhilR8 PhilR8 temporarily deployed to dev October 6, 2023 16:53 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

✨ See the Django Site in action ✨

@PhilR8 PhilR8 temporarily deployed to dev October 6, 2023 17:11 — with GitHub Actions Inactive
@PhilR8 PhilR8 temporarily deployed to dev October 6, 2023 17:14 — with GitHub Actions Inactive
@PhilR8 PhilR8 temporarily deployed to dev October 6, 2023 17:18 — with GitHub Actions Inactive
@PhilR8 PhilR8 temporarily deployed to dev October 6, 2023 17:18 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

✨ See the Django Site in action ✨

@PhilR8 PhilR8 temporarily deployed to dev October 6, 2023 17:24 — with GitHub Actions Inactive
@PhilR8 PhilR8 marked this pull request as ready for review October 6, 2023 17:31
@PhilR8 PhilR8 added the Needs Review This PR needs a code review label Oct 6, 2023
cgodwin1
cgodwin1 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@cgodwin1 cgodwin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PhilR8 PhilR8 removed the Needs Review This PR needs a code review label Oct 6, 2023
@PhilR8 PhilR8 merged commit fdf4714 into main Oct 6, 2023
18 checks passed
@PhilR8 PhilR8 temporarily deployed to dev October 6, 2023 17:49 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgodwin1 cgodwin1 cgodwin1 approved these changes

@thwalker6 thwalker6 Awaiting requested review from thwalker6

@peggles2 peggles2 Awaiting requested review from peggles2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilR8 @cgodwin1