Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HCBS] Create Submission Dashboard #32

Merged
merged 8 commits into from
Sep 25, 2024
Merged

[HCBS] Create Submission Dashboard #32

merged 8 commits into from
Sep 25, 2024

Conversation

ajaitasaini
Copy link
Contributor

@ajaitasaini ajaitasaini commented Sep 11, 2024

Description

Related ticket(s)

CMDCT-3948


How to test

make sure you can see this page
image

Important updates


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

@ajaitasaini ajaitasaini marked this pull request as ready for review September 13, 2024 14:13
BearHanded
BearHanded previously approved these changes Sep 20, 2024
Copy link
Contributor

@benmartin-coforma benmartin-coforma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm requesting changes for rendering.ts - the rest of my comments are more idle musing.

Copy link
Contributor

@rocio-desantiago rocio-desantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lingering import comments to be removed. Do we need to keep new lines in the import section?

Copy link

codeclimate bot commented Sep 25, 2024

Code Climate has analyzed commit 37a93bb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 80.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 74.3% (0.2% change).

View more on Code Climate.

@braxex braxex merged commit 509ddb7 into main Sep 25, 2024
16 of 17 checks passed
@braxex braxex deleted the qm-dashboard branch September 25, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants