-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HCBS] Create Submission Dashboard #32
Conversation
services/ui-src/src/components/accordions/InstructionsAccordion.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm requesting changes for rendering.ts
- the rest of my comments are more idle musing.
services/ui-src/src/components/accordions/InstructionsAccordian.test.tsx
Outdated
Show resolved
Hide resolved
services/ui-src/src/components/pages/Dashboard/DashboardTable.tsx
Outdated
Show resolved
Hide resolved
services/ui-src/src/components/pages/Dashboard/DashboardPage.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lingering import comments to be removed. Do we need to keep new lines in the import section?
Code Climate has analyzed commit 37a93bb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 80.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 74.3% (0.2% change). View more on Code Climate. |
Description
Related ticket(s)
CMDCT-3948
How to test
make sure you can see this page
Important updates
Author checklist
convert to a different template: test → val | val → prod