Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple changes. See description #11

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

abratnap
Copy link

  • Added poetry for packaging
  • Added formatting with black and pylint
  • Travis to build and publish docker image (Need help from admin with publishing)
  • Updated README (Also added the youtube link)

Copy link
Collaborator

@dasanind dasanind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to run the Jupyter notebooks when you were running the app in virtual environment?

I was trying to add pylint to the github workflow so that it run on every pull request.

README.md Outdated Show resolved Hide resolved
fix earlier merge issue and put back curl commands
@abratnap
Copy link
Author

We can plan using github workflow if you prefer. Currently enabled travis-ci.

@abratnap
Copy link
Author

I've not tested the notebook code. I have tested the docker build and image being created so notebook code should work. Can you please point me to the notebook you would like to test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants