Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting inconsistency #560

Open
wants to merge 1 commit into
base: uinverse
Choose a base branch
from

Conversation

EdwinChang24
Copy link

It came to my attention that an inconsistency in formatting was present, therefore I felt obliged to amend it. Please visit my office in the janitor's closet on the west side of floor 17 for inquiries.

@@ -8,7 +8,7 @@
*/
public final class FizzBuzzOutputStrategyToFizzBuzzExceptionSafeOutputStrategyAdapter implements FizzBuzzExceptionSafeOutputStrategy {

private final FizzBuzzOutputStrategy _fizzBuzzOutputStrategy;
private final FizzBuzzOutputStrategy _fizzBuzzOutputStrategy;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should only be one space following the keyword private rather than three spaces. Please revise your PR to reflect the code formatting seen in existing instances of private final such as on line 17 in the LoopComponentFactory.

My proposed change to your PR looks like this:

private final FizzBuzzOutputStrategy _fizzBuzzOutputStrategy;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants