Rewrite the very real enterprise project of totally not a satire project to C++ (real) #694

GEOEGII555 · 2024-07-08T13:05:26Z

Hello,

At enterprise quality programming Co. LTD, performance is one of the top priorities that a company would have. The slower the performance is, the less clients a company would have. It's one of our top goals to maximize the performance.

That being said, while Java is a great programming language, it can't beat the speed of C and C++.

So, in order to maximize the performance of the fizz buzz: enterprise edition, and to beat the competitors, we need to rewrite Fizz Buzz: Enterprise Edition in C++.

While it's possible to write assembly code that has better performance than C++, it would cost too much. Most C++ compilers, such as the Microsoft MSVC compiler, generate very fast executables, where optimizing it further is not worth it.

Since we are on C++, our very serious enterprise project only supports the very serious enterprise platform called "Windows NT", we can leverage:

The native Windows API. Java has a translator which translates the instructions for a specific operating system. However, since we're only on Windows NT, we can avoid doing such conversions and instead directly use the Windows API.

We also don't have to worry about destroying the performance and significantly increasing the dependency count when leveraging:

The C++ standard library. It has a lot of useful things which don't destroy the performance, unlike Java. It also doesn't require a lot of dependencies (just an 11 gigibyte installation of Visual Studio) to run quickly and without performance issues.
I haven't listed all of the upsides of rewriting our very serious enterprise project to C++.

The only downside of this is that we will be using the Windows API, which means that if some company ever decides to use Linukz as their operating system, even though it's not a serious business environment, they won't be able to use our project, which will lead to revenue loss.

This pull request closes #693.

There's one question: do we add tests?

// isn't this supposed to be easy

Capital-Asterisk

A few things. would be cool to have CMake support and C++23 too.

argparser.cpp

argparser.hpp

console.cpp

fizz_buzz.hpp

output_writer.cpp

fizz_buzz.hpp

console.cpp

GEOEGII555 · 2024-07-15T08:06:12Z

A few things. would be cool to have CMake support and C++23 too.

We upgraded the project standard to C++23.

Thanks for the suggestion about using CMake, however, our very serious totally not satire company only uses serious business tools, such as Microsoft Visual Studio 2022, and not Linukz KitWare CMake.

Capital-Asterisk · 2024-07-15T21:03:16Z

There better be tests for std::basic_string; must be sure that they work properly

GEOEGII555 · 2024-10-29T13:29:33Z

Requesting a review because changes were done to src/code/README.md.

Danmyrer · 2024-10-29T14:54:28Z

@GEOEGII555 have you considered that C++ is older than Java? Shouldn't migration efforts be directed towards newer technologies? Company wants us to use the latest and most hyped technologies to keep our stack more competitive in the future.

GEOEGII555 · 2024-11-01T11:20:33Z

@GEOEGII555 have you considered that C++ is older than Java? Shouldn't migration efforts be directed towards newer technologies?

Please keep in mind that C++ is used to this day. I saw a popular commonly used project which is still on C++11 (August 2011)! Can't remember the exact name though. This PR uses a newer version of C++.

Company wants us to use the latest and most hyped technologies to keep our stack more competitive in the future.

If you look at the latest update release date, both are new. If you look at the date of the initial release, we should be moving away from Java to a new programming language no one else uses.

Currently, C++23 is used. It was released in December 2023, which is a year ago. It's relatively new compared to the C++ versions other commercial products use.

PurHur · 2024-11-01T12:32:44Z

We should consult some tech leads that will decide if raw c++ is secure enough for this software. I guess some parts could be written in rust to make is more secure.

GEOEGII555 · 2024-11-02T07:05:18Z

We should consult some tech leads that will decide if raw c++ is secure enough for this software. I guess some parts could be written in rust to make is more secure.

While I'm not a Rust developer in any kind, in my opinion, combining Rust and C++ would be more unsafe than using raw C++ or raw Rust. Also please keep in mind that Rust compilation is slow.

jedwards1211 · 2024-11-07T18:09:43Z

Hmmm, needs some dependency injection via templates

rillig

The patch looks good indeed. I just have a few stylistic remarks.

rillig · 2024-11-07T21:31:10Z

argparser.cpp

+#include <vector>
+#include "argparser.hpp"
+
+TCHAR helpMessage[] = TEXT("Usage: [program] [--output file] [--enable_cache cache_file] [--source source]\n\


Why is the help message not marked constexpr? Having a text this large in a writeable memory page may impact performance, in case the page needs an extra copy-on-write.

rillig · 2024-11-07T21:32:33Z

argparser.cpp

+\t\ttestinput - A fake input source. It inputs all numbers from 1 to 100 (both sides included).\n");
+
+// See the help message above for more info about these flags.
+constexpr TCHAR HELP_FLAG[] = TEXT("--help");


Would it make sense to add static here to avoid the external linkage? That should result in a smaller executable file.

rillig · 2024-11-07T21:34:38Z

argparser.cpp

+		else if (lstrcmp(*it, OUTPUT_FILENAME_FLAG) == 0) {
+			std::advance(it, 1);
+			if (it >= argvVector.end()) {
+				showHelp = true;


There should be an error indicator, as a plain --help should exit successfully, while this case should exit erroneously.

rillig · 2024-11-07T21:43:40Z

console.cpp

+#include <algorithm>
+#include <ranges>
+
+_console::_console() {


For internationalization, it may be useful to switch the console window to UTF-8. I did a proof of concept a few years ago. My approach is not very enterprisey, but maybe you can convert it to something more professional.

rillig · 2024-11-07T21:49:33Z

input_reader.cpp

+		abort();
+	}
+	unsigned long long int fileSize;
+	GetFileSizeEx(this->hFile, (PLARGE_INTEGER) & fileSize);


The error handling is missing here.

rillig · 2024-11-07T21:50:45Z

input_reader.cpp

+	if (temp == 0) {
+		_this->inputExhausted = true;
+		throw std::exception("There's nothing more in the input.");
+		return -1;


The return statement is redundant.

rillig · 2024-11-07T21:52:28Z

main.cpp

+
+// Welcome to 2024, where open source projects have a copyright.
+TCHAR copyrightMessage[] = {
+	TEXT("FizzBuzz Enterprise Edition.\nEnterpriseQualityCoding - the most serious and not satire or fake company in the uinverse.\n")


Typo: uinverse -> universe

GEOEGII555 added 16 commits July 8, 2024 12:15

Get rid of slow code

cbd5a88

convert into a visual studio project

f901147

remove temporary folder

a801e21

Add a .gitignore file

56a216a

add a console interface and a typedef for a string that uses TCHARs

5e5a652

Add an argument parser

f333340

Add an input reader

943d122

Create _FizzBuzzer

d0e0477

Add an output writer

1d8dbcf

Add a fake input stream, which just spams numbers from 1 to 100

6e6808f

Check if the file is empty.

4362181

fix

304a98f

more bug fixes

55295bc

// isn't this supposed to be easy

Add a readme

7723292

Fix file writing, update .gitignore

a4531d8

Already fixed

57f3932

GEOEGII555 mentioned this pull request Jul 8, 2024

Achieve better performance by rewriting to C++ #693

Open

GEOEGII555 added 3 commits July 8, 2024 18:15

Add persistent cache (not tested)

b4e8a09

Close the file handles.

f79272c

Fix persistent caching.

65242b6

Capital-Asterisk reviewed Jul 14, 2024

View reviewed changes

GEOEGII555 added 8 commits July 15, 2024 10:58

Made flags be constant expressions.

6c1455b

Use getter functions instead of direct class member access.

580325c

Added 2 interfaces.

f6ab067

Change the loop to std::ranges::for_each with std::views::iota

c9d36c2

Use tostringstreams instead of normal strings in baseoutputwriter

8c00abc

Use inline instead of extern

f4550d9

Change the loop to use iterators instead. Also fix a couple of bugs.

2254cd1

rvalue ref

950127b

GEOEGII555 mentioned this pull request Sep 6, 2024

We should port to Rust #702

Closed

This was referenced Oct 29, 2024

Rewrite in Javascript #704

Open

It's not memory-safe, please rewrite it in Rust #705

Open

No hardware acceleration support #708

Open

GEOEGII555 requested a review from Capital-Asterisk October 29, 2024 13:25

Update README.md

ff091b1

This was referenced Oct 29, 2024

Upgrade to Java 20 #679

Open

The code syntax is too simple, please complicate it. #701

Open

Deprication warning!!!!!!!!1111!!!!!!!!!!!!111!!!!!! #653

Open

Cease and Desist #652

Open

GEOEGII555 mentioned this pull request Nov 1, 2024

Discussion for #694 - should I simplify the code, leave it as it is already or make it more complex? #711

Open

This was referenced Nov 2, 2024

A cloudy threat looms on the horizon #709

Open

Move to Quarkus #581

Open

Reduce COBOL code #571

Open

rillig reviewed Nov 7, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rewrite the very real enterprise project of totally not a satire project to C++ (real) #694

Rewrite the very real enterprise project of totally not a satire project to C++ (real) #694

GEOEGII555 commented Jul 8, 2024 •

edited

Loading

Capital-Asterisk left a comment

GEOEGII555 commented Jul 15, 2024 •

edited

Loading

Capital-Asterisk commented Jul 15, 2024

GEOEGII555 commented Oct 29, 2024

Danmyrer commented Oct 29, 2024

GEOEGII555 commented Nov 1, 2024 •

edited

Loading

PurHur commented Nov 1, 2024

GEOEGII555 commented Nov 2, 2024

jedwards1211 commented Nov 7, 2024

rillig left a comment

rillig Nov 7, 2024

rillig Nov 7, 2024

rillig Nov 7, 2024

rillig Nov 7, 2024

rillig Nov 7, 2024

rillig Nov 7, 2024

rillig Nov 7, 2024

Rewrite the very real enterprise project of totally not a satire project to C++ (real) #694

Are you sure you want to change the base?

Rewrite the very real enterprise project of totally not a satire project to C++ (real) #694

Conversation

GEOEGII555 commented Jul 8, 2024 • edited Loading

Capital-Asterisk left a comment

Choose a reason for hiding this comment

GEOEGII555 commented Jul 15, 2024 • edited Loading

Capital-Asterisk commented Jul 15, 2024

GEOEGII555 commented Oct 29, 2024

Danmyrer commented Oct 29, 2024

GEOEGII555 commented Nov 1, 2024 • edited Loading

PurHur commented Nov 1, 2024

GEOEGII555 commented Nov 2, 2024

jedwards1211 commented Nov 7, 2024

rillig left a comment

Choose a reason for hiding this comment

rillig Nov 7, 2024

Choose a reason for hiding this comment

rillig Nov 7, 2024

Choose a reason for hiding this comment

rillig Nov 7, 2024

Choose a reason for hiding this comment

rillig Nov 7, 2024

Choose a reason for hiding this comment

rillig Nov 7, 2024

Choose a reason for hiding this comment

rillig Nov 7, 2024

Choose a reason for hiding this comment

rillig Nov 7, 2024

Choose a reason for hiding this comment

GEOEGII555 commented Jul 8, 2024 •

edited

Loading

GEOEGII555 commented Jul 15, 2024 •

edited

Loading

GEOEGII555 commented Nov 1, 2024 •

edited

Loading