Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: type hinting for pipeline and transformation #189

Closed
wants to merge 2 commits into from

Conversation

maestro-1
Copy link
Contributor

@maestro-1 maestro-1 commented Jul 23, 2023

Initial add of types to the sequence class and the functions of transformation module
This is an initial commit for #118

The Sequence class has a parameter of no_wraps which is a keyword argument. By all indications, this is a boolean but the default parameter used was None. This can lead to confusion if not properly understood, so type hints have been included to specify it as a boolean, and the default parameter has been changed from None to False. They would run the same way, but False is more semantically accurate in this context.

The typing module is deprecated in more recent versions of python, but generics still need to be carried out using TypeVar until python 3.12. For backward compatibility using TypeVar is preferable.

@maestro-1 maestro-1 force-pushed the feature-type-hinting branch from b4e7c3e to b2864bc Compare July 23, 2023 23:39
@maestro-1 maestro-1 closed this Jul 23, 2023
@maestro-1 maestro-1 reopened this Jul 23, 2023
@maestro-1 maestro-1 closed this Jul 23, 2023
@maestro-1 maestro-1 deleted the feature-type-hinting branch July 23, 2023 23:46
@maestro-1 maestro-1 restored the feature-type-hinting branch July 23, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant