Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing false injection #1188

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Removing false injection #1188

merged 1 commit into from
Jun 18, 2021

Conversation

cmungall
Copy link
Member

Fixes #1187

note once this is merged it will take a long time for the fix to propagate depending on the R0 rate for ontology infection

@cmungall cmungall requested a review from pbuttigieg June 17, 2021 23:58
pbuttigieg
pbuttigieg approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@pbuttigieg pbuttigieg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, supportive of this - we don't really use this at the moment, opting for use of synonyms with associated comments / editor notes if needed.

@cmungall
Copy link
Member Author

Thanks! We do actually use this, in that the bridge module is imported by envo-edit, and merged into the final release

@cmungall cmungall merged commit c278876 into master Jun 18, 2021
@cmungall cmungall deleted the cmungall-patch-1 branch June 18, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbuttigieg pbuttigieg pbuttigieg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

envo_bridge is injecting a problematic IAO annotation
2 participants
@cmungall @pbuttigieg