Modularize Bazel build #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofeing
force-pushed
the
modularize-bazel
branch
from
fe70319 to
e79843f
Compare
|
@wsmoses the tests pass. the failing tests are not due to this PR and are also failing on main. |
wsmoses
reviewed
Dec 28, 2024
wsmoses
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following EnzymeAD/Reactant.jl#421, I'm moving build deps to different files inside the
third_partyfolder.I would prefer to also pack the calls in
WORKSPACEbecause it's similar in ReactantExtra, but we can do that later.