[EnzymeTestUtils] Fix batch duplicated return and aliasing return/argument #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
changed the title
|
@wsmoses, can you please add a test that was failing before this PR but now passes? It's not clear to me what edge case this solves. |
|
Yeah will add a test later today for post-commit review (sorry for quick push, am trying to push new version in fix to fix the accidentally failing NNlib tests which turn out to be correct: FluxML/NNlib.jl#536) |
michel2323
pushed a commit
that referenced
this pull request
Nov 7, 2023
…ument (#1079) * Fix batch duplicated return * Handle aliasing input and outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.