Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increases network read timeout to 5 minutes when sending a payment via HTTP #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NicolasFlamel1
Copy link

This change increases the network read timeout to 5 minutes when sending a payment via HTTP. This fixes sending payments to people using the Epic Cash Ledger hardware wallet app which can take up to a minute to create a bulletproof.

The 5 minute read timeout is only applied when sending a receive_tx request, and all other requests will still use the default read timeout. This avoids any unnecessary waiting when sending a payment since a check_version request always comes before a receive_tx request.

@who-biz
Copy link
Contributor

who-biz commented Jun 15, 2023

Looks fine to me. Will review once focus shifts back to Ledger integrations.

We should test thoroughly to ensure that this does not affect regular network txs adversely.

@who-biz
Copy link
Contributor

who-biz commented Mar 4, 2024

Ledger work on hold indefinitely. We'll see if their listing queue opens up in bull market. Also throwing around the idea of a more privacy-focused Ledger fork. But low priority atm.

Open for discussion if we wish to elevate to higher priority.

@who-biz who-biz added low priority Non-urgent for any number of reasons on hold Related initiative is on hold, for now labels Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Non-urgent for any number of reasons on hold Related initiative is on hold, for now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants