Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes decoding emoji slates that contain a slate with non-ASCII characters #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NicolasFlamel1
Copy link

Fixes decoding emoji slates that contain messages with non-ASCII characters.

This can be tested by running the following commands
epic-wallet send -m emoji -g "😃" 1
epic-wallet receive -m emoji -i "..."

Without this PR you'll get the following errors since participant messages containing non-ASCII characters, like 😃, aren't decoded correctly.

ERROR verify_messages - participant message doesn't match signature. Message: "ð"
ERROR Error validating participant messages: Signature error: Optional participant messages do not match signatures
Wallet command failed: LibWallet Error: Signature error: Optional participant messages do not match signatures

@who-biz
Copy link
Contributor

who-biz commented Jun 14, 2023

Thanks Nicolas! Will review ASAP. Emoji transactions were written by the Brick Abode team, who are now taking a less active role in maintaining our repositories/writing code.

This feature was added right around the time I came onboard to the project, so may take me a bit to review.

Thanks for the first PR(s)!

@who-biz
Copy link
Contributor

who-biz commented Dec 22, 2023

@johanneshahn have you tested and confirmed this issue, and that it resolves the error?

@who-biz
Copy link
Contributor

who-biz commented Mar 4, 2024

Adding a note here to say that I'll test this myself soon, and we'll get it merged. Looks fine to me.

@who-biz who-biz self-assigned this Mar 4, 2024
@who-biz who-biz added bug Something isn't working in progress Working on it labels Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress Working on it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants