Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Support composition for mobile keyboards #442

Closed
wants to merge 1 commit into from

Conversation

gunsha
Copy link
Contributor

@gunsha gunsha commented Nov 28, 2023

Relevant components:

  • Signalling server
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

Currently when using mobile keyboards using the suggestion bar or asian keyboards (chinese/japanese) is not supported as this uses the composition event on the keyboard

Solution

added composition event handler on mobile devices

Test Plan and Compatibility

working example of the changes implemented
https://arcanemirage.com/project/394?token=hLVbruBPrnR8

posible fix for #194

Copy link
Contributor

PRs go stale after 30 days of inactivity. Please comment or re-open the PR if you are still working on this PR.

@github-actions github-actions bot added the stale label Dec 29, 2023
@github-actions github-actions bot closed this Dec 29, 2023
@DenisTensorWorks DenisTensorWorks added enhancement New feature or request and removed stale labels Jan 7, 2024
@lukehb
Copy link
Contributor

lukehb commented Feb 16, 2024

Since this PR has been opened this commit was landed: 8b838f4

Is there other changes in this PR beyond support for composition events that we should consider? If so, please update the PR to the latest changes and update the description with any other issues it is addressing. However, I believe we support composition on mobile with the above linked commit?

@lukehb
Copy link
Contributor

lukehb commented Feb 19, 2024

Bump @gunsha for you comments on the above. ^

@gunsha
Copy link
Contributor Author

gunsha commented Feb 19, 2024

@lukehb can't find time to do a real test with the repo, but looking at the changes it's kind of the same I implemented, the only difference I see is that the composition and keypress events are always registered, i saw some input duplication when having both at the same time, so i'm only initializing composition on mobile and keypress on desktop

@lukehb
Copy link
Contributor

lukehb commented Feb 20, 2024

@gunsha Let us know if you do see any duplication using what is in master currently. I am going to close for now as it is likely a new PR would be required if there is any bugfix for duplicated input.

@lukehb lukehb closed this Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants