More uses of ArgumentOutOfRangeException throw helpers (dotnet#10423)

Epica3055 · Dec 28, 2023 · b6b8611 · b6b8611
1 parent 25fd629
commit b6b8611
Show file tree

Hide file tree

Showing 51 changed files with 139 additions and 924 deletions.
diff --git a/src/System.Windows.Forms.Primitives/src/System/IntrinsicExtensions.cs b/src/System.Windows.Forms.Primitives/src/System/IntrinsicExtensions.cs
diff --git a/src/System.Windows.Forms.Primitives/src/System/Windows/Forms/Count.cs b/src/System.Windows.Forms.Primitives/src/System/Windows/Forms/Count.cs
@@ -14,7 +14,11 @@ namespace System.Windows.Forms;
 {
     private readonly int _count;
 
-    private Count(int count) => _count = count.OrThrowIfNegative();
+    private Count(int count)
+    {
+        ArgumentOutOfRangeException.ThrowIfNegative(count);
+        _count = count;
+    }
 
     public static Count Zero { get; } = 0;
     public static Count One { get; } = 1;

diff --git a/src/System.Windows.Forms/src/Resources/SR.resx b/src/System.Windows.Forms/src/Resources/SR.resx
@@ -3462,9 +3462,6 @@ Stack trace where the illegal operation occurred was:
   <data name="InvalidCrossThreadControlCall" xml:space="preserve">
     <value>Action being performed on this control is being called from the wrong thread. Marshal to the correct thread using Control.Invoke or Control.BeginInvoke to perform this action.</value>
   </data>
-  <data name="InvalidExBoundArgument" xml:space="preserve">
-    <value>Value of '{1}' is not valid for '{0}'. '{0}' should be greater than {2} and less than {3}.</value>
-  </data>
   <data name="InvalidFileFormat" xml:space="preserve">
     <value>File format is not valid.</value>
   </data>
@@ -3474,18 +3471,6 @@ Stack trace where the illegal operation occurred was:
   <data name="InvalidGDIHandle" xml:space="preserve">
     <value>Win32 handle passed to {0} is not valid or is the wrong type.</value>
   </data>
-  <data name="InvalidHighBoundArgument" xml:space="preserve">
-    <value>Value of '{1}' is not valid for '{0}'. '{0}' must be less than {2}.</value>
-  </data>
-  <data name="InvalidHighBoundArgumentEx" xml:space="preserve">
-    <value>Value of '{1}' is not valid for '{0}'. '{0}' must be less than or equal to {2}.</value>
-  </data>
-  <data name="InvalidLowBoundArgument" xml:space="preserve">
-    <value>Value of '{1}' is not valid for '{0}'. '{0}' must be greater than {2}.</value>
-  </data>
-  <data name="InvalidLowBoundArgumentEx" xml:space="preserve">
-    <value>Value of '{1}' is not valid for '{0}'. '{0}' must be greater than or equal to {2}.</value>
-  </data>
   <data name="InvalidNullArgument" xml:space="preserve">
     <value>Null is not a valid value for '{0}'.</value>
   </data>

diff --git a/src/System.Windows.Forms/src/Resources/xlf/SR.cs.xlf b/src/System.Windows.Forms/src/Resources/xlf/SR.cs.xlf
diff --git a/src/System.Windows.Forms/src/Resources/xlf/SR.de.xlf b/src/System.Windows.Forms/src/Resources/xlf/SR.de.xlf
diff --git a/src/System.Windows.Forms/src/Resources/xlf/SR.es.xlf b/src/System.Windows.Forms/src/Resources/xlf/SR.es.xlf
diff --git a/src/System.Windows.Forms/src/Resources/xlf/SR.fr.xlf b/src/System.Windows.Forms/src/Resources/xlf/SR.fr.xlf
diff --git a/src/System.Windows.Forms/src/Resources/xlf/SR.it.xlf b/src/System.Windows.Forms/src/Resources/xlf/SR.it.xlf
diff --git a/src/System.Windows.Forms/src/Resources/xlf/SR.ja.xlf b/src/System.Windows.Forms/src/Resources/xlf/SR.ja.xlf