Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :IsVerified rank filter, and support to block command runs from non-verified users. #1564

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

prpldev
Copy link

@prpldev prpldev commented Jun 29, 2024

Proof of functionality: https://streamable.com/u522zd
(%UNKNOWN% was fixed, was due to a variable being the wrong letter.)

Suggested originally by vfx_1.

@prpldev
Copy link
Author

prpldev commented Jun 29, 2024

Please let me know if I've missed a command or a core part of running/processing commands, I believe I've covered all bases, but it's my first PR to Adonis so it's very possible I missed something.

@Dimenpsyonal Dimenpsyonal added the ✨ enhancement Enhancing or improving existing functionality label Jun 29, 2024
@coasterteam
Copy link
Collaborator

this honestly feels more like a plugin for free admin games than anything else

@prpldev
Copy link
Author

prpldev commented Jun 29, 2024

this honestly feels more like a plugin for free admin games than anything else

I feel as though it has more functionality than just Free Admin based games. Any game that sells admin privileges or large roleplay groups that use point based promotions that allow for admin use (a large portion of these games use adonis).

@prpldev
Copy link
Author

prpldev commented Jun 29, 2024

I feel as though it has more functionality than just Free Admin based games. Any game that sells admin privileges or large roleplay groups that use point based promotions that allow for admin use (a large portion of these games use adonis).

As well as any game that gives the AddAdmin based commands to their moderators.

@ccuser44
Copy link
Contributor

We already have this as a plugin https://github.com/Epix-Incorporated/Adonis-Plugins/blob/master/Server/Server-VerificationLock.luau

Thia doesn't really make sense to be in the main Adonis code base

@prpldev
Copy link
Author

prpldev commented Jun 30, 2024

We already have this as a plugin https://github.com/Epix-Incorporated/Adonis-Plugins/blob/master/Server/Server-VerificationLock.luau

Thia doesn't really make sense to be in the main Adonis code base

The plugin and the code in my PR have different functions.

@prpldev prpldev changed the title Add :IsVerified rank filter, and support to block all non-verified admins. Add :IsVerified rank filter, and support to block command runs from non-verified users. Jun 30, 2024
@Dimenpsyonal
Copy link
Member

Needs to have settings.Desc and settings.Order in settings and defaultsettings

@ccuser44
Copy link
Contributor

ccuser44 commented Jul 1, 2024

We already have this as a plugin https://github.com/Epix-Incorporated/Adonis-Plugins/blob/master/Server/Server-VerificationLock.luau

Thia doesn't really make sense to be in the main Adonis code base

The plugin and the code in my PR have different functions.

This still doesn't make sense in the main Adonis code base. Please convert this to a third party plugin. We already have plenty of settings.

Don't get me wrong the feature is great and useful in some cases, but the cases where it is useful are quite rarw so i don't see that it should exist as a built-in feature. Hence I think you should convert this to a third party plugin

@prpldev
Copy link
Author

prpldev commented Jul 1, 2024

Needs to have settings.Desc and settings.Order in settings and defaultsettings

Added.

No need for creators to return true to a value on a rank filter.
@Expertcoderz Expertcoderz added the ⚡ command Specific Adonis commands label Jul 3, 2024
@P3tray
Copy link
Contributor

P3tray commented Jul 8, 2024

I like this. Please merge.

@LolloDev5123
Copy link
Contributor

This PR is not boring, however it would be best not to add bloat and move existing bloat to the dedicated plugin repo

@P3tray
Copy link
Contributor

P3tray commented Jul 18, 2024

This PR is not boring, however it would be best not to add bloat and move existing bloat to the dedicated plugin repo

Maintainers when one line is added to the million line settings file.

@prpldev
Copy link
Author

prpldev commented Nov 18, 2024

this has been sitting so long that it now has conflicts, so i will fix those 🫡

@Dimenpsyonal
Copy link
Member

Dimenpsyonal commented Nov 22, 2024

Ooor you could add it as a plugin at Adonis Plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ command Specific Adonis commands ✨ enhancement Enhancing or improving existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants