-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add :IsVerified rank filter, and support to block command runs from non-verified users. #1564
base: master
Are you sure you want to change the base?
Conversation
Please let me know if I've missed a command or a core part of running/processing commands, I believe I've covered all bases, but it's my first PR to Adonis so it's very possible I missed something. |
this honestly feels more like a plugin for free admin games than anything else |
I feel as though it has more functionality than just Free Admin based games. Any game that sells admin privileges or large roleplay groups that use point based promotions that allow for admin use (a large portion of these games use adonis). |
As well as any game that gives the AddAdmin based commands to their moderators. |
We already have this as a plugin https://github.com/Epix-Incorporated/Adonis-Plugins/blob/master/Server/Server-VerificationLock.luau Thia doesn't really make sense to be in the main Adonis code base |
The plugin and the code in my PR have different functions. |
Needs to have settings.Desc and settings.Order in settings and defaultsettings |
This still doesn't make sense in the main Adonis code base. Please convert this to a third party plugin. We already have plenty of settings. Don't get me wrong the feature is great and useful in some cases, but the cases where it is useful are quite rarw so i don't see that it should exist as a built-in feature. Hence I think you should convert this to a third party plugin |
Added. |
No need for creators to return true to a value on a rank filter.
I like this. Please merge. |
This PR is not boring, however it would be best not to add bloat and move existing bloat to the dedicated plugin repo |
Maintainers when one line is added to the million line settings file. |
this has been sitting so long that it now has conflicts, so i will fix those 🫡 |
Ooor you could add it as a plugin at Adonis Plugins |
Proof of functionality: https://streamable.com/u522zd
(%UNKNOWN% was fixed, was due to a variable being the wrong letter.)
Suggested originally by vfx_1.