FF-2465 Make orderPosition 1-indexed to match UI #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greghuels
force-pushed
the
greg/FF-2465/order-position-fix
branch
2 times, most recently
from
09d83f2
to
ebed05a
Compare
aarsilv
approved these changes
Jun 27, 2024
| @@ -62,7 +62,7 @@ export class Evaluator { | |||
| unmatchedAllocations.push({ | |||
| key: allocation.key, | |||
| allocationEvaluationCode: code, | |||
| orderPosition: i, | |||
| orderPosition: i + 1, | |||
| @@ -103,16 +103,17 @@ export class FlagEvaluationDetailsBuilder { | |||
| this.matchedAllocation = { | |||
| key: allocation.key, | |||
| allocationEvaluationCode: AllocationEvaluationCode.MATCH, | |||
| orderPosition, | |||
| orderPosition: indexPosition + 1, // orderPosition is 1-indexed to match UI | |||
There was a problem hiding this comment.
I appreciate the comment! 🙏
greghuels
merged commit e7e2dba
into
greg/FF-2465/evaluation-reasons
1 of 2 checks passed
greghuels
added a commit
that referenced
this pull request
Jul 2, 2024
* FF-2465 rename flag-evaluation-details.ts to flag-evaluation-details-builder.ts * FF-2465 make orderPosition 1-indexed to match UI * FF-2465 include IAssignmentDetails in exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In the new "Assignment Details" object,
orderPositionis confusing since it's 0-indexed, when the UI shows the assignments as 1-indexed.See also: Eppo-exp/sdk-test-data#37 for test data fix
Description
Updates
orderPositionso that it's now 1-indexed. This is part of the "Evaluation Reasons" work and will be merged in to the base branch for that feature.How has this been tested?
local testing