FF-2465 adds "environment" and "allocation.name" to details #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
approved these changes
Jun 28, 2024
greghuels
force-pushed
the
greg/FF-2526/ufc-environment
branch
2 times, most recently
from
b396353
to
b8f67b8
Compare
|
I verified locally that the test data passes with this change. |
greghuels
commented
Jul 1, 2024
Comment on lines
+252
to
+254
| describe.each(getTestFilePaths())('for file: %s', (testFilePath: string) => { | ||
| const testCase = parseJSON(testFilePath); | ||
| describe.each(testCase.subjects.map(({ subjectKey }) => subjectKey))( |
There was a problem hiding this comment.
I re-wrote how this works so that the error messages are more clear and so that it's easier to debug
greghuels
commented
Jul 1, 2024
greghuels
force-pushed
the
greg/FF-2526/ufc-environment
branch
from
5cb1ea9
to
091be90
Compare
sameerank
approved these changes
Jul 1, 2024
| const flagEvaluationDetailsBuilder = new FlagEvaluationDetailsBuilder( | ||
| configDetails.configEnvironment.name, |
There was a problem hiding this comment.
Note to self: typescript ensures we don't need optional chaining here because of the environment interface in ConfigDetails, configEnvironment: Environment;
greghuels
force-pushed
the
greg/FF-2526/ufc-environment
branch
from
091be90
to
b57be38
Compare
greghuels
added a commit
that referenced
this pull request
Jul 2, 2024
* FF-2465 adds "environment" and "allocation.name" to details * FF-2526 update to accommodate EnvironmentDto * FF-2526 FF-2526 fix "environment" and code review changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FF-2465
Motivation and Context
This change was motivated by internal feedback.
Description
Adds
environmentandassignments[].nameto the new "assignment details" functionality.How has this been tested?
verified test data works with updated change
Manual testing:
