featu: [Add support for exporting the configuration[ (FF-2437) #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecsl
approved these changes
Jun 18, 2024
sameerank
approved these changes
Jun 18, 2024
|
Not sure if these questions are related, but here they go:
|
Yes this is a good observation. I am planning on allowing the JS client to configure itself in obfuscated or non obfuscated mode, the latter being for this use case of importing a configuration from nodejs. Do you see concerns with this approach, assuming the customer is aware of the security relaxation they are performing?
Cool yea now that we have the go ahead should complete that work to expose it. |
leoromanovsky
force-pushed
the
lr/ff-2437/export-all
branch
from
185784a
to
0de5177
Compare
leoromanovsky
commented
Jul 1, 2024
| @@ -41,6 +41,6 @@ export interface ISyncStore<T> { | |||
| export interface IAsyncStore<T> { | |||
| isInitialized(): boolean; | |||
| isExpired(): Promise<boolean>; | |||
| getEntries(): Promise<Record<string, T>>; | |||
There was a problem hiding this comment.
@felipecsl you had a review comment to rename getAll to entries. Ok for me to also rename getEntries to entries for consistency?
aarsilv
pushed a commit
that referenced
this pull request
Jul 2, 2024
* featu: [Add support for exporting the configuration[ (FF-2437) * rename getAll to entries * getFlagConfigurations * bump to 3.4.0
aarsilv
added a commit
that referenced
this pull request
Jul 3, 2024
* Fetch and store bandit parameters (#85) * bandit config store added * fix typo * test case * feedback from PR * Aaron/ff 2407/bandit evaluator (#88) * don't fetch bandit parameters if no store provided * stubbed methods for bandit evaluation * failing attribute scoring test * score actions tests passing * clean up from rebase * scoring working * weights test in place * tests passing * feedback from PR * Bandit selects and assigns action from weighted actions (#95) * action selection working, but suspect * failing JS test case * shared test cases passing * shared bandit tests passing * intermediate test case passing * fix test assignment weights * bandit logger test * handle when no actions * tests passing * changes from self-review of PR * additional note for future PR * remove comments from bandit logger interface * feedback from PR * fix remaining issues from rebase * Update for updated shared test data (#104) * update for shared test data updates * get ready for updated sdk test data * todo with failing test * store bandit flag to action association * rearrange parameters * feedback from PR * Handle explicitly bucketed numeric and categorical attributes (#108) * file names for test cases * support explicitly bucketed attributes * subject attribute test * tests WIP * final tests passing * all tests passing * need to export bandit logger interfaces * feedback from PR * featu: [Add support for exporting the configuration[ (FF-2437) (#90) * featu: [Add support for exporting the configuration[ (FF-2437) * rename getAll to entries * getFlagConfigurations * bump to 3.4.0 * bump feature version * add bandit store setters to interface --------- Co-authored-by: Leo Romanovsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #issue
Motivation and Context
Users who want to bootstrap their client SDK need a mechanism to export the configuration from their NodeJS server.
Description
Adds a new method to the client called
getConfiguration- it is implemented by exporting the contents of theservingStore: SyncStore. This is implemented as aMapand trivial to export all the flags. The top-level method returns the UFC response.Customers will be instructed to serialize this to JSON if desired and transmit it over an internal API.
How has this been tested?
New unit tests.