FF-2526 fix tests for assignmentDetails object #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greghuels
commented
Jul 1, 2024
| "environment": { | ||
| "name": "Test" | ||
| }, | ||
| "environmentName": "Test", |
There was a problem hiding this comment.
keeping this as a top-level field so that it isn't nested (when logging to Chrome console for instance). The UFC response still has environment as an object though.
There was a problem hiding this comment.
Oh true, nested objects are a hassle to sift through in console logs 👍
sameerank
approved these changes
Jul 1, 2024
| "environment": { | ||
| "name": "Test" | ||
| }, | ||
| "environmentName": "Test", |
There was a problem hiding this comment.
Oh true, nested objects are a hassle to sift through in console logs 👍
greghuels
added a commit
that referenced
this pull request
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a mistake in the structure of the assignmentDetails object. See original PR: #38