quality: Round 2 of SDK test workflow migrations #58
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,9 +4,30 @@ on: | |
| push: | ||
| branches: | ||
| - main | ||
| - tp/workflows/round2 | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
|
|
||
| test-java-sdk: | ||
|
There was a problem hiding this comment. lots of duplicated code, have you considered using a matrix? Unchecked example from ChatGPT: test-sdks:
runs-on: ubuntu-latest
strategy:
matrix:
sdk:
- { repo: "java-server-sdk", workflow: "lint-test-sdk.yml", ref: "tp/workflows/remote" }
- { repo: "php-sdk", workflow: "run-tests.yml", ref: "main" }
- { repo: "js-client-sdk", workflow: "lint-test-sdk.yml", ref: "tp/workflows/remote" }
- { repo: "python-sdk", workflow: "lint-test-sdk.yml", ref: "tp/workflows/remote" }
steps:
- name: Display workflow details
shell: bash
run: |
echo "Testing eppo-exp/${{ matrix.sdk.repo }}"
- name: Run remote workflow
uses: convictional/[email protected]
with:
owner: Eppo-exp
repo: ${{ matrix.sdk.repo }}
workflow_file_name: ${{ matrix.sdk.workflow }}
ref: ${{ matrix.sdk.ref }}
github_token: ${{ secrets.AUTH_TOKEN }}
wait_interval: 10
propagate_failure: true
trigger_workflow: true
wait_workflow: trueThere was a problem hiding this comment. I hadn't, in fact. 🧑🍳 |
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Display workflow details | ||
| shell: bash | ||
| run: | | ||
| echo "Testing Eppo-exp/java-server-sdk" | ||
| - name: Run remote workflow | ||
| uses: convictional/[email protected] | ||
| with: | ||
| owner: Eppo-exp | ||
| repo: java-server-sdk | ||
| workflow_file_name: lint-test-sdk.yml | ||
| ref: tp/workflows/remote | ||
|
There was a problem hiding this comment. If you merge these first I imagine you won't need this There was a problem hiding this comment. that's right; will remove these refs after SDK PRs are merged |
||
| github_token: ${{ secrets.AUTH_TOKEN }} | ||
| wait_interval: 10 | ||
| propagate_failure: true | ||
| trigger_workflow: true | ||
| wait_workflow: true | ||
|
|
||
| test-php-sdk: | ||
| runs-on: ubuntu-latest | ||
|
|
@@ -28,6 +49,46 @@ jobs: | |
| trigger_workflow: true | ||
| wait_workflow: true | ||
|
|
||
| test-node-client-sdk: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Display workflow details | ||
| shell: bash | ||
| run: | | ||
| echo "Testing eppo-exp/js-client-sdk" | ||
| - name: Run remote workflow | ||
| uses: convictional/[email protected] | ||
| with: | ||
| owner: Eppo-exp | ||
| repo: js-client-sdk | ||
| workflow_file_name: lint-test-sdk.yml | ||
| ref: tp/workflows/remote | ||
| github_token: ${{ secrets.AUTH_TOKEN }} | ||
| wait_interval: 10 | ||
| propagate_failure: true | ||
| trigger_workflow: true | ||
| wait_workflow: true | ||
|
|
||
| test-python-sdk: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Display workflow details | ||
| shell: bash | ||
| run: | | ||
| echo "Testing eppo-exp/python-sdk" | ||
| - name: Run remote workflow | ||
| uses: convictional/[email protected] | ||
| with: | ||
| owner: Eppo-exp | ||
| repo: python-sdk | ||
| workflow_file_name: lint-test-sdk.yml | ||
| ref: tp/workflows/remote | ||
| github_token: ${{ secrets.AUTH_TOKEN }} | ||
| wait_interval: 10 | ||
| propagate_failure: true | ||
| trigger_workflow: true | ||
| wait_workflow: true | ||
|
|
||
| test-node-server-sdk: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
temporary I'm guessing?
What about running these shared tests on all pull requests, like we do for the individual SDKs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test-sdks.ymlis for in-flight changes; we don't want to make the SDKs in their respective repos until the test cases are checked in.Temporary indeed; removed.