test macro: set model_node_being_tested before caller() instead of after
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psousa50
approved these changes
Jul 23, 2024
psousa50
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the use case for #210 was to be able to build up queries in the
dbt_unit_testing.test()block using model metadata, e.g. the columns list.I am noticing that sometimes
model_node_being_testedis not set at the execution time ofcaller(). For some of our models it is fine, for some it isn't. I am not sure what the difference is.Was there a reason that the context is only being set after
caller()? Is there any harm in doing it earlier like proposed in this PR?