Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
webgui-new
only calls theCppService
as a Language Service.This is an issue when requesting information such as
getAstNodeInfoByPosition
since theCppService
gets called even if we are not viewing C++ files.In this patch, I added a universal
language-service
forwebgui-new
, which decides the service to call based on file type.Before using this
language-service
, one should callcreateClient
with a file type and then it creates the appropriate Thrift connection.I also replaced existing
CppService
calls with the newlanguage-service
.For the codemirror-editor, I also added a
languageExtension
function, which selects the correct CodeMirror extension for syntax highlight.