Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create workspace symlink in log folder, load on resume #368

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

ErikBjare
Copy link
Owner

@ErikBjare ErikBjare commented Dec 29, 2024

This is a step towards fixing #262 by storing the workspace path in the log folder, which can then in turn be used for workspace-relative file lookups.


Important

In chat() in gptme/chat.py, create a symlink for the workspace in the log directory if it doesn't exist, resolving the path if it does.

  • Behavior:
    • In chat() in gptme/chat.py, create a symlink workspace in logdir if it doesn't exist and workspace is not provided.
    • Resolve workspace path if log_workspace symlink already exists.
  • Misc:
    • Add TODO comment to consider moving workspace logic into LogManager.

This description was created by Ellipsis for 76c0ab8. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 76c0ab8 in 31 seconds

More details
  • Looked at 23 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_es96txeKTose6hWK


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

gptme/chat.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.23%. Comparing base (0d642c2) to head (76c0ab8).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
+ Coverage   71.19%   71.23%   +0.04%     
==========================================
  Files          68       68              
  Lines        5416     5417       +1     
==========================================
+ Hits         3856     3859       +3     
+ Misses       1560     1558       -2     
Flag Coverage Δ
anthropic/claude-3-haiku-20240307 70.03% <100.00%> (+0.04%) ⬆️
openai/gpt-4o-mini 68.93% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErikBjare ErikBjare merged commit 0347510 into master Dec 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants