Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Head packs #41

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Head packs #41

wants to merge 6 commits into from

Conversation

Thatsmusic99
Copy link
Collaborator

Head packs are a feature I previously brainstormed in mid-2019, however, I believe were scrapped for reasons I personally don't recall. Although, now I have the basic framework to make them a possible feature for the much-delayed v7 update, which overhauls a lot of HeadsPlus's major features; this is just scratching the surface.

In addition to this, this will be the first feature of HeadsPlus to provide full support for HD/transparent heads.

These packs are fetched from a repo (currently Thatsmusic99/HeadsPlusHeadPacks, which will be made public in the future) and downloaded locally so they can easily be enabled and disabled whenever. By default, all packs are disabled and must be in a set format. If they are not in a set format when submitted, changes must be requested, and only I will be able to make changes to said packs on demand. If the user modifies the pack format resulting in it not being readable, a warning is sent and then the entire pack is ignored by the plugin until prompted to be checked again through /hp reload or /hp pack enable/disable. When the head pack is loaded, all heads are loaded even if the section is disabled, meaning those heads can be used in mob drops and crafting.

As of currently, the following criteria still need to be met:

  • Create contributing guidelines for Thatsmusic99/HeadsPlusHeadPacks
  • Allow the plugin to download packs from the repo as soon as it is open
  • Create the /hp pack subcommand. Since the configuration is getting reworked in v7 as well, messages will all be placeholders.
  • Add head textures to the allHeadsCache.
  • Make heads from their packs allow custom prices, including a default price for the pack.
  • Allow the possibility for a donation option so users can donate to head pack authors.
  • Set up proper validation so the plugin doesn't completely die when something isn't quite right.

@Thatsmusic99 Thatsmusic99 changed the base branch from v7 to master November 17, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant