Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agegroup when arcade #25

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

asafevenpaz
Copy link

I have added explanations on how to use the Arcade expression "When" for cases when the data includes an "Age" field but the user wants to group the data into age groups

@ekenes
Copy link
Contributor

ekenes commented Feb 24, 2020

Sorry @asafevenpaz. I didn't see this one. Is this ready for review?

@asafevenpaz
Copy link
Author

Sorry @asafevenpaz. I didn't see this one. Is this ready for review?

Yes. Please review and test

Copy link
Contributor

@ekenes ekenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asafevenpaz can you add a link to the https://github.com/Esri/arcade-expressions/blob/master/any/README.md that would direct to this page? That will help make this page more discoverable.

@@ -0,0 +1,17 @@
# when_agegroup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this text for the link is fine, but can you format this so it's more readable? Maybe something like "Date to age group" or something that describes the function to be used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized this doesn't deal with Date fields. It's still numbers...so it could be even more generic, like "Number to category"

any/when_agegroup.md Outdated Show resolved Hide resolved
any/when_agegroup.md Outdated Show resolved Hide resolved
any/when_agegroup.md Outdated Show resolved Hide resolved
asafevenpaz and others added 3 commits February 24, 2020 12:42
Co-Authored-By: Kristian Ekenes <[email protected]>
Co-Authored-By: Kristian Ekenes <[email protected]>
Co-Authored-By: Kristian Ekenes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants