2.4.0 changes to safe_streets_to_schools sample

[ManushiM]

changes made

1. Rendering and other map changes to reflect new map widget changes
2. Few changes to the markdown description.

Also tested this against https://github.com/ArcGIS/geoserpent/pull/190 and it works smoothly.

refer to ArcGIS:geosaurus/12343

---

Checklist

Please go through each entry in the below checklist and mark an 'X' if that condition has been met. Every entry should be marked with an 'X' to be get the Pull Request approved.

• All imports are in the first cell?
  • First block of imports are standard libraries
  • Second block are 3rd party libraries
  • Third block are all arcgis imports? Note that in some cases, for samples, it is a good idea to keep the imports next to where they are used, particularly for uncommonly used features that we want to highlight.
• All GIS object instantiations are one of the following?
  • gis = GIS()
  • gis = GIS('home') or gis = GIS('pro')
  • gis = GIS(profile="your_online_portal")
  • gis = GIS(profile="your_enterprise_portal")
• If this notebook requires setup or teardown, did you add the appropriate code to ./misc/setup.py and/or ./misc/teardown.py?
• If this notebook references any portal items that need to be staged on AGOL/Python API playground, did you coordinate with a Python API team member to stage the item the correct way with the api_data_owner user?
• If the notebook requires working with local data (such as CSV, FGDB, SHP, Raster files), upload the files as items to the Geosaurus Online Org using api_data_owner account and change the notebook to first download and unpack the files.
• Code simplified & split out across multiple cells, useful comments?
• Consistent voice/tense/narrative style? Thoroughly checked for typos?
• All images used like <img src="base64str_here"> instead of <img src="https://some.url">? All map widgets contain a static image preview? (Call mapview_inst.take_screenshot() to do so)
• All file paths are constructed in an OS-agnostic fashion with os.path.join()? (Instead of r"\foo\bar", os.path.join(os.path.sep, "foo", "bar"), etc.)
• Is your code formatted using Jupyter Black? You can use Jupyter Black to format your code in the notebook.
• If this notebook showcases deep learning capabilities, please go through the following checklist:
  • Are the inputs required for Export Training Data Using Deep Learning tool published on geosaurus org (api data owner account) and added in the notebook using gis.content.get function?
  • Is training data zipped and published as Image Collection? Note: Whole folder is zipped with name same as the notebook name.
  • Are the inputs required for model inferencing published on geosaurus org (api data owner account) and added in the notebook using gis.content.get function? Note: This includes providing test raster and trained model.
  • Are the inferenced results displayed using a webmap widget?
• IF YOU WANT THIS SAMPLE TO BE DISPLAYED ON THE DEVELOPERS.ARCGIS.COM WEBSITE, ping @jyaistMap so he can add it to the list for the next deploy.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-11-20T07:19:44Z
----------------------------------------------------------------

Line #1.    m1 = gis.map('Pasadena, California', 13)

zoom level need to be set separately

jyaistMap commented on 2024-11-22T23:39:40Z
----------------------------------------------------------------

The zoom has to be performed after the map has been rendered. The code as is will draw the exact same widget if you were to run this code:

m1 = gis.map("Pasadena, California")

m1.zoom = 2

m1.basemap.basemap = "topo-vector"

m1

Please move the m1.zoom = 13 to its own cell after the map has been rendered.

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-11-20T07:19:44Z
----------------------------------------------------------------

Line #1.    m2 = gis.map('Pasadena, California', 13)

same here, set zoom level separately

jyaistMap commented on 2024-11-22T23:41:49Z
----------------------------------------------------------------

Same issue as above. The map widget will not recognize a zoom level before it is rendered. It has to be rendered first and then the zoom can be applied. m2.zoom = 13 has to be in a cell on its own after the map has already been rendered.

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-11-20T07:19:45Z
----------------------------------------------------------------

Line #1.    m3 = gis.map('Pasadena, California', 13)

same here, set zoom level separately

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-11-20T07:19:46Z
----------------------------------------------------------------

Line #1.    m4 = gis.map('Pasadena, California', 13)

same here, set zoom level separately

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-11-20T07:19:46Z
----------------------------------------------------------------

Line #1.    uv

cell output is missing

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-11-20T07:19:47Z
----------------------------------------------------------------

Looks like the unique_value_list is the same as uv. Maybe we can just use uv as the list for renderer?

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-11-20T07:19:48Z
----------------------------------------------------------------

Line #1.    m6 = gis.map('Pasadena, California', 13)

same here, set zoom level separately

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-11-20T07:19:49Z
----------------------------------------------------------------

Line #1.    m7 = gis.map('Pasadena, California', 13)

same here, set zoom level separately

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-11-20T07:19:50Z
----------------------------------------------------------------

Line #1.    m8 = gis.map('Pasadena, California', 13)

same here, set zoom level separately

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-11-20T07:19:50Z
----------------------------------------------------------------

Line #1.    m9 = gis.map('Pasadena, California', 13)

same here, set zoom level separately

[cariashuang0417]

Thanks for updates @ManushiM ! Just left some comments (mostly the same) for zoom level tweaks. Overall looks good!

I am not 100% sure about the arcade expression, so will need help on double check this from @nanaeaubry . I've just tested the symbols and renderers locally and all looks good on maps. Great job Manushi, and I learned a lot from your changes in advanced mapping. 😃

[nanaeaubry]

@ManushiM Looks good, same comments as Shuang and the rendering looks correct.

[ManushiM]

Thanks for the great feedback @cariashuang0417 and @nanaeaubry . I made the necessary changes.

[cariashuang0417]

All looks good! 🥇

[jyaistMap]

The zoom has to be performed after the map has been rendered. The code as is will draw the exact same widget if you were to run this code:

m1 = gis.map("Pasadena, California")

m1.zoom = 2

m1.basemap.basemap = "topo-vector"

m1

Please move the m1.zoom = 13 to its own cell after the map has been rendered.

---

View entire conversation on ReviewNB

[jyaistMap]

Same issue as above. The map widget will not recognize a zoom level before it is rendered. It has to be rendered first and then the zoom can be applied. m2.zoom = 13 has to be in a cell on its own after the map has already been rendered.

---

View entire conversation on ReviewNB

[jyaistMap]

Hi @ManushiM

• all the map cells need changed because the zoom will not change the view of the map widget unless it's run after a map has been rendered. Maps appear the same no matter what zoom you set before being rendered:
  

The zoom has to be run after:

• Please remove all the mx.zoom = level lines from the map cells and move them to a cell directly after the map has been rendered.

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

jyaistMap commented on 2024-11-25T20:38:00Z
----------------------------------------------------------------

Please remove the text after the word profile.

[ManushiM]

@jyaistMap Thank you for the change recommendation for zoom . I changed it only for cells where the map rendered was significantly different.