-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Clone a Group guide updated #2314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two small comments
"metadata": {}, | ||
"outputs": [ | ||
{ | ||
"data": { | ||
"text/html": [ | ||
"<div class=\"9item_container\" style=\"height: auto; overflow: hidden; border: 1px solid #cfcfcf; border-radius: 2px; background: #f6fafa; line-height: 1.21429em; padding: 10px;\">\n", | ||
" <div class=\"item_left\" style=\"width: 210px; float: left;\">\n", | ||
" <a href='https://pythonapi.playground.esri.com/portal/home/group.html?id=32d87e01dd734563a377a1c5b82425fa' target='_blank'>\n", | ||
" <a href='https://rpubw120iwapt.ags.esri.com/portal/home/group.html?id=84664d956490472f89d7ba14a84fbed8' target='_blank'>\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jyaistMap Unsure about this one so will defer to you but do we want to expose this enterprise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left one question, otherwise looks good
@@ -26,12 +26,13 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #9. description=item.description)
Thumbnail could be one of the parameters here if you want to keep the content as before
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just left one suggestion for the thumbnail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, Tarun! Apart from the suggestion from Shuang, I have a question:
Since this is a guide, do we also want to mention a note for 2 capabilities in the API?
- groups.clone() - will clone the group to another org, but won't clone the items. Might help to add this note so users don't feel surprised when their content doesn't clone.
- Does it make sense to link to the GroupMigrationManager as an alternative pattern for those who want to generate an offline export package?
major changes: