This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
feat(block): prevent disabled block content from being tabbed into #652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #548
Summary
This sets tabIndex on the host component to prevent shadow DOM content from being accessed via the keyboard.
From WICG/inert#48:
A downside to this approach is that the user-set
tabindex
is not preserved when a block is disabled and reenabled (or vice versa).Another change in this PR is that any slotted control is no longer hidden when the block is disabled since the component is no longer interactive.
cc @kat10140
Questions