Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox, stepper, table): respect user hidden attribute #10983

Merged
merged 31 commits into from
Jan 22, 2025
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
6dfa7c9
fix(combobox, stepper, table): respect user hidden attribute
josercarcamo Dec 4, 2024
cddcabd
Merge branch 'dev' into josercarcamo/8623-respect-user-hidden-attribu…
josercarcamo Dec 12, 2024
ff38449
Merged dev
josercarcamo Jan 8, 2025
e843d98
Fixed all e2e tests for combobox
josercarcamo Jan 8, 2025
e425670
Fixed all tests for table
josercarcamo Jan 8, 2025
1c3680c
Removed unnecessary change
josercarcamo Jan 8, 2025
4772e23
Changed hideItem to hiddenItem and fixed test cases
josercarcamo Jan 9, 2025
46686b4
Finished addressing all code review comments
josercarcamo Jan 9, 2025
dfb66ae
Added hidden-item mixin
josercarcamo Jan 9, 2025
759791a
Removed unnecessary test change
josercarcamo Jan 10, 2025
eee513d
Merged dev
josercarcamo Jan 13, 2025
3e38b65
Merge branch 'dev' into josercarcamo/8623-respect-user-hidden-attribu…
josercarcamo Jan 13, 2025
284d75c
Merge branch 'dev' into josercarcamo/8623-respect-user-hidden-attribu…
josercarcamo Jan 13, 2025
09af985
Merge branch 'dev' into josercarcamo/8623-respect-user-hidden-attribu…
josercarcamo Jan 17, 2025
c88ca71
Used html formatter
josercarcamo Jan 17, 2025
a90211f
Parameterized disabled/hidden
josercarcamo Jan 17, 2025
7d1f446
Changed step number to integer
josercarcamo Jan 17, 2025
f8a9016
Removed optional chaining operator; fixed combobox e2e error
josercarcamo Jan 17, 2025
37cabf8
Refactored statement in test per code review
josercarcamo Jan 18, 2025
3e146b9
Removed unnecessary test per review
josercarcamo Jan 18, 2025
1d4a2d3
Renamed argument to el
josercarcamo Jan 18, 2025
a46227d
Replaced conditional with use of isHidden
josercarcamo Jan 18, 2025
da25db2
Changed test to step through hidden element
josercarcamo Jan 18, 2025
ca3fedc
Fixed combobox test failure
josercarcamo Jan 20, 2025
a3ea10a
Fixed errors caused by hidden combobox item'
josercarcamo Jan 20, 2025
7da4daa
Merge branch 'dev' into josercarcamo/8623-respect-user-hidden-attribu…
josercarcamo Jan 20, 2025
4f6d67a
Changed wording of comment and name of argument
josercarcamo Jan 21, 2025
e07beac
Merge branch 'josercarcamo/8623-respect-user-hidden-attribute-v2' of …
josercarcamo Jan 21, 2025
8c8c883
Renamed 'hiddenItem' to 'calciteHidden'
josercarcamo Jan 22, 2025
d867b85
Renamed 'calciteHidden' to 'itemHidden'
josercarcamo Jan 22, 2025
26f24a1
Merge branch 'dev' into josercarcamo/8623-respect-user-hidden-attribu…
josercarcamo Jan 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changed step number to integer
josercarcamo committed Jan 17, 2025
commit 7d1f446da951ccdb58be159941d1ea923bc1e143
Original file line number Diff line number Diff line change
@@ -878,12 +878,12 @@ describe("calcite-stepper", () => {
<calcite-stepper-item heading="Step 2" id="step-2" disabled>
<div>Step 2 content</div>
</calcite-stepper-item>
<calcite-stepper-item heading="Step 2.1" id="step-2.1" hidden>
<div>Step 2.1 content</div>
</calcite-stepper-item>
<calcite-stepper-item heading="Step 3" id="step-2">
<calcite-stepper-item heading="Step 3" id="step-3" hidden>
<div>Step 3 content</div>
</calcite-stepper-item>
<calcite-stepper-item heading="Step 4" id="step-4">
<div>Step 4 content</div>
</calcite-stepper-item>
</calcite-stepper>`,
);